Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add other policies in CEL expressions - Part 2 #960

Merged
merged 29 commits into from
May 16, 2024
Merged

feat: add other policies in CEL expressions - Part 2 #960

merged 29 commits into from
May 16, 2024

Conversation

Chandan-DK
Copy link
Contributor

@Chandan-DK Chandan-DK commented Mar 30, 2024 •
edited
Loading

Related Issue(s)

Partially addresses #891

Description

This PR includes the conversion of policies in the other folder to Kyverno CEL policies. Conversion of the policies will be done in multiple PRs

Policies converted in this PR:

  • enforce-pod-duration
  • enforce-readwriteonce-pod
  • ensure-probes-different
  • ensure-readonly-hostpath
  • forbid-cpu-limits to cel
  • imagepullpolicy-always
  • ingress-host-match-tls
  • limit-containers-per-pod
  • limit-hostpath-type-pv

Checklist

  • [] I have read the policy contribution guidelines.
  • [] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
  • [] I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

@MariamFahmy98 MariamFahmy98 self-assigned this Mar 31, 2024
@MariamFahmy98 MariamFahmy98 self-requested a review March 31, 2024 15:53
@Chandan-DK
copy forbid-cpu-limits
7df7c8f 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
convert forbid-cpu-limits to cel
c0a44b6 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
copy limit-containers-per-pod
bcd7bf3 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
convert limit-containers-per-pod to cel
e3b216e 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
copy pdb-maxunavailable
6e3ea37 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
convert pdb-maxunavailable to cel
bbc2c33 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
keep pdb-maxunavailable in a separate PR
84630b5 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
copy imagepullpolicy-always
18235cd 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
convert imagepullpolicy-always to cel
4b6c0a0 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK Chandan-DK marked this pull request as ready for review April 6, 2024 18:04
MariamFahmy98
MariamFahmy98 reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@MariamFahmy98 MariamFahmy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor comments.

other-cel/enforce-readwriteonce-pod/enforce-readwriteonce-pod.yaml Outdated Show resolved Hide resolved
other-cel/enforce-readwriteonce-pod/artifacthub-pkg.yml Outdated Show resolved Hide resolved
MariamFahmy98
MariamFahmy98 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@MariamFahmy98 MariamFahmy98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MariamFahmy98
Copy link
Contributor

@Chandan-DK - Could you please resolve the conflicts?

@MariamFahmy98 MariamFahmy98 merged commit 7e55ff1 into kyverno:main May 16, 2024
163 of 164 checks passed
@Chandan-DK Chandan-DK deleted the other-policies-cel-part-2 branch June 7, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariamFahmy98 MariamFahmy98 MariamFahmy98 approved these changes

Assignees

@MariamFahmy98 MariamFahmy98

Labels
None yet
Projects
Good First Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chandan-DK @MariamFahmy98