Skip to content

Commit

Permalink
fix: incorrect expectation api docs (#833)
Browse files Browse the repository at this point in the history
Signed-off-by: Charles-Edouard Brétéché <[email protected]>
  • Loading branch information
eddycharly authored Feb 9, 2024
1 parent a06d0eb commit 043a1e4
Show file tree
Hide file tree
Showing 9 changed files with 27 additions and 20 deletions.
9 changes: 6 additions & 3 deletions .crds/chainsaw.kyverno.io_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,8 @@ spec:
be considered.
properties:
check:
description: Match defines the matching statement.
description: Check defines the verification
statement.
type: object
x-kubernetes-preserve-unknown-fields: true
match:
Expand Down Expand Up @@ -470,7 +471,8 @@ spec:
be considered.
properties:
check:
description: Match defines the matching statement.
description: Check defines the verification
statement.
type: object
x-kubernetes-preserve-unknown-fields: true
match:
Expand Down Expand Up @@ -510,7 +512,8 @@ spec:
be considered.
properties:
check:
description: Match defines the matching statement.
description: Check defines the verification
statement.
type: object
x-kubernetes-preserve-unknown-fields: true
match:
Expand Down
6 changes: 3 additions & 3 deletions .crds/chainsaw.kyverno.io_teststeps.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ spec:
determine if the verification should be considered.
properties:
check:
description: Match defines the matching statement.
description: Check defines the verification statement.
type: object
x-kubernetes-preserve-unknown-fields: true
match:
Expand Down Expand Up @@ -411,7 +411,7 @@ spec:
determine if the verification should be considered.
properties:
check:
description: Match defines the matching statement.
description: Check defines the verification statement.
type: object
x-kubernetes-preserve-unknown-fields: true
match:
Expand Down Expand Up @@ -450,7 +450,7 @@ spec:
determine if the verification should be considered.
properties:
check:
description: Match defines the matching statement.
description: Check defines the verification statement.
type: object
x-kubernetes-preserve-unknown-fields: true
match:
Expand Down
1 change: 1 addition & 0 deletions .release-notes/main.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ Release notes for `TODO`.

- Fixed an issue when running `chainsaw migrate kuttl tests` twice on the same folder
- Fixed an issue with `chainsaw migrate kuttl tests` potentially incorrect when a `TestStep` is present
- Fixed an incorrect `Expectation` API docs

## 📚 Docs 📚

Expand Down
6 changes: 3 additions & 3 deletions .schemas/json/test-chainsaw-v1alpha1.json
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,7 @@
],
"properties": {
"check": {
"description": "Match defines the matching statement.",
"description": "Check defines the verification statement.",
"x-kubernetes-preserve-unknown-fields": true
},
"match": {
Expand Down Expand Up @@ -1013,7 +1013,7 @@
],
"properties": {
"check": {
"description": "Match defines the matching statement.",
"description": "Check defines the verification statement.",
"x-kubernetes-preserve-unknown-fields": true
},
"match": {
Expand Down Expand Up @@ -1071,7 +1071,7 @@
],
"properties": {
"check": {
"description": "Match defines the matching statement.",
"description": "Check defines the verification statement.",
"x-kubernetes-preserve-unknown-fields": true
},
"match": {
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/v1alpha1/expectation.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ type Expectation struct {
// +optional
Match *Check `json:"match,omitempty"`

// Match defines the matching statement.
// Check defines the verification statement.
Check Check `json:"check"`
}
9 changes: 6 additions & 3 deletions pkg/data/crds/chainsaw.kyverno.io_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,8 @@ spec:
be considered.
properties:
check:
description: Match defines the matching statement.
description: Check defines the verification
statement.
type: object
x-kubernetes-preserve-unknown-fields: true
match:
Expand Down Expand Up @@ -470,7 +471,8 @@ spec:
be considered.
properties:
check:
description: Match defines the matching statement.
description: Check defines the verification
statement.
type: object
x-kubernetes-preserve-unknown-fields: true
match:
Expand Down Expand Up @@ -510,7 +512,8 @@ spec:
be considered.
properties:
check:
description: Match defines the matching statement.
description: Check defines the verification
statement.
type: object
x-kubernetes-preserve-unknown-fields: true
match:
Expand Down
6 changes: 3 additions & 3 deletions pkg/data/crds/chainsaw.kyverno.io_teststeps.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ spec:
determine if the verification should be considered.
properties:
check:
description: Match defines the matching statement.
description: Check defines the verification statement.
type: object
x-kubernetes-preserve-unknown-fields: true
match:
Expand Down Expand Up @@ -411,7 +411,7 @@ spec:
determine if the verification should be considered.
properties:
check:
description: Match defines the matching statement.
description: Check defines the verification statement.
type: object
x-kubernetes-preserve-unknown-fields: true
match:
Expand Down Expand Up @@ -450,7 +450,7 @@ spec:
determine if the verification should be considered.
properties:
check:
description: Match defines the matching statement.
description: Check defines the verification statement.
type: object
x-kubernetes-preserve-unknown-fields: true
match:
Expand Down
6 changes: 3 additions & 3 deletions pkg/data/schemas/json/test-chainsaw-v1alpha1.json
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,7 @@
],
"properties": {
"check": {
"description": "Match defines the matching statement.",
"description": "Check defines the verification statement.",
"x-kubernetes-preserve-unknown-fields": true
},
"match": {
Expand Down Expand Up @@ -1013,7 +1013,7 @@
],
"properties": {
"check": {
"description": "Match defines the matching statement.",
"description": "Check defines the verification statement.",
"x-kubernetes-preserve-unknown-fields": true
},
"match": {
Expand Down Expand Up @@ -1071,7 +1071,7 @@
],
"properties": {
"check": {
"description": "Match defines the matching statement.",
"description": "Check defines the verification statement.",
"x-kubernetes-preserve-unknown-fields": true
},
"match": {
Expand Down
2 changes: 1 addition & 1 deletion website/docs/apis/chainsaw.v1alpha1.md
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ with a match filter to determine if the verification should be considered.</p>
| Field | Type | Required | Inline | Description |
|---|---|---|---|---|
| `match` | `policy/v1alpha1.Any` | | | <p>Match defines the matching statement.</p> |
| `check` | `policy/v1alpha1.Any` | :white_check_mark: | | <p>Match defines the matching statement.</p> |
| `check` | `policy/v1alpha1.Any` | :white_check_mark: | | <p>Check defines the verification statement.</p> |

## `FileRef` {#chainsaw-kyverno-io-v1alpha1-FileRef}

Expand Down

0 comments on commit 043a1e4

Please sign in to comment.