[RG] Made separate settings for Sul-Xan Soulweaver's Soul Remnant

kyoma · Nov 8, 2021 · 60c4aa8 · 60c4aa8
1 parent f3c8ca8
commit 60c4aa8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/Settings.lua b/Settings.lua
@@ -307,6 +307,7 @@ do ------------------
 		rockgrove = {
 			sulxan_reaver_sundering_strike = 0, -- "Off"
 			sulxan_soulweaver_astral_shield = false,
+			sulxan_soulweaver_soul_remnant = false,
 			prime_meteor = false,
 			havocrel_barbarian_hasted_assault = false,
 			oaxiltso_savage_blitz = false,
@@ -1656,6 +1657,11 @@ function RaidNotifier:CreateSettingsMenu()
 		name = L.Settings_Rockgrove_Astral_Shield,
 		tooltip = L.Settings_Rockgrove_Astral_Shield_TT,
 	}, "rockgrove", "sulxan_soulweaver_astral_shield")
+	MakeControlEntry({
+		type = "checkbox",
+		name = L.Settings_Rockgrove_Soul_Remnant,
+		tooltip = L.Settings_Rockgrove_Soul_Remnant_TT,
+	}, "rockgrove", "sulxan_soulweaver_soul_remnant")
 	MakeControlEntry({
 		type = "checkbox",
 		name = L.Settings_Rockgrove_Prime_Meteor,

diff --git a/TrialRockgrove.lua b/TrialRockgrove.lua
@@ -104,7 +104,7 @@ function RaidNotifier.RG.OnCombatEvent(_, result, isError, aName, aGraphic, aAct
     elseif (result == ACTION_RESULT_EFFECT_FADED) then
         -- Sul-Xan Soulweaver's Soul Remnant attack (his Astral Shield is broken)
         if (abilityId == buffsDebuffs.sulxan_soulweaver_astral_shield_self) then
-            if (settings.sulxan_soulweaver_astral_shield) then
+            if (settings.sulxan_soulweaver_soul_remnant) then
                 self:AddAnnouncement(GetString(RAIDNOTIFIER_ALERTS_ROCKGROVE_SOUL_REMNANT), "rockgrove", "sulxan_soulweaver_astral_shield")
             end
         end

diff --git a/lang/en.lua b/lang/en.lua
@@ -589,7 +589,9 @@ L.Settings_Rockgrove_Header                        = "Rockgrove"
 L.Settings_Rockgrove_Sundering_Strike              = "General: Sundering Strike"
 L.Settings_Rockgrove_Sundering_Strike_TT           = "Alerts you when the Sul-Xan Reaper makes Sundering Strike attack. Roll dodge it."
 L.Settings_Rockgrove_Astral_Shield                 = "General: Astral Shield"
-L.Settings_Rockgrove_Astral_Shield_TT              = "Alerts you when the Sul-Xan Soulweaver casts his Astral Shield, and when Soul Remnants affect you."
+L.Settings_Rockgrove_Astral_Shield_TT              = "Alerts you when the Sul-Xan Soulweaver casts his Astral Shield."
+L.Settings_Rockgrove_Soul_Remnant                  = "General: Soul Remnant (Soulweaver)"
+L.Settings_Rockgrove_Soul_Remnant_TT               = "Alerts you when Soul Remnants targets you (as result of breaking Sul-Xan Soulweaver's Astral Shield)."
 L.Settings_Rockgrove_Prime_Meteor                  = "General: Prime Meteor"
 L.Settings_Rockgrove_Prime_Meteor_TT               = "Shows countdown when meteor appears indicating the time before it explodes. Make sure to kill the meteor in time."
 L.Settings_Rockgrove_Hasted_Assault                = "General: Hasted Assault"