Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing not set operation.CloudProvider when provisioner is managing cluster #1515

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Fixing not set operation.CloudProvider when provisioner is managing cluster #1515

merged 2 commits into from
Dec 2, 2024

Conversation

jaroslaw-pieszka
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Fallback to inputCreator if operation.CloudProvider not set in Create-Runtime-Resource-Step (when KIM is driving)

Related issue(s)

https://github.tools.sap/kyma/backlog/issues/6451

@jaroslaw-pieszka jaroslaw-pieszka requested a review from a team as a code owner December 2, 2024 14:46
@jaroslaw-pieszka jaroslaw-pieszka self-assigned this Dec 2, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 2, 2024
@jaroslaw-pieszka jaroslaw-pieszka added kind/bug Categorizes issue or PR as related to a bug. and removed cla: yes Indicates the PR's author has signed the CLA. labels Dec 2, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) December 2, 2024 14:46
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 2, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 2, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit ac4567f into kyma-project:main Dec 2, 2024
32 checks passed
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekMichali MarekMichali MarekMichali approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@MarekMichali MarekMichali

Labels
cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaroslaw-pieszka @MarekMichali @kyma-bot @kyma-gopher-bot