Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing way extensions are handled in KIM and matchers #535

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Changing way extensions are handled in KIM and matchers #535

wants to merge 19 commits into from

Conversation

akgalwas
Copy link
Contributor

@akgalwas akgalwas commented Nov 28, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fix for overwriting DNS during upgrade
  • Fix for overwriting OIDC during upgrade
  • Fix for matchers to detect unwanted updates of the extension list
  • DNS extender no longer sets reference to dns credentials secret
  • spec.resources is taken into account during the comparison.

Related issue(s)
#533

@akgalwas akgalwas requested a review from a team as a code owner November 28, 2024 10:31
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2024
@akgalwas akgalwas changed the title Added extender taking DNS config from the shoot Changing way extensions are handled in KIM and matchers Nov 28, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 28, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akgalwas @kyma-bot @m00g3n