Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict the controller to watch only kcp-system namespace #524

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Restrict the controller to watch only kcp-system namespace #524

merged 6 commits into from
Nov 26, 2024

Conversation

mvshao
Copy link
Contributor

@mvshao mvshao commented Nov 25, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • restricted the Infrastructure Manager controller to watch GardnenerClusterCRs, and RuntimeCRs which were only created in kcp-system

Related issue(s)
#449

@mvshao mvshao requested a review from a team as a code owner November 25, 2024 11:17
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 25, 2024
@Disper
Copy link
Member

Disper commented Nov 25, 2024

To be verified if it will not resolve #56 as well.

@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2024
Disper
Disper approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@Disper Disper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I would like to also play with it on DEV when promoted.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 26, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 26, 2024
Disper
Disper previously approved these changes Nov 26, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 26, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 26, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 26, 2024
@kyma-bot kyma-bot merged commit d45e2fe into kyma-project:main Nov 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Disper Disper Disper approved these changes

Assignees

@Disper Disper

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvshao @Disper @kyma-bot