Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDCConfig is now optional #393

Closed

Conversation

Disper
Copy link
Member

@Disper Disper commented Sep 20, 2024

Description

Changes proposed in this pull request:

  • OIDCConfig is now optional to support the first flow defined here.
  • ...
  • ...

Related issue(s)

@Disper Disper requested a review from a team as a code owner September 20, 2024 11:34
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2024
@Disper
Copy link
Member Author

Disper commented Sep 20, 2024

PRs for MPC should also be prepared.
/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2024
@Disper
Copy link
Member Author

Disper commented Oct 2, 2024

Closing as this part is merged to #384 which also includes the breaking change around converter so having this as a separate PR no longer is as valuable.

@Disper Disper closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants