Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated comment in pull-target-e2e workflow #429

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Updated comment in pull-target-e2e workflow #429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pull-target-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: pull-target-e2e

## NOTE: This workflow uses the GitHub event `pull_request_target`, which uses the base commit instead of the head.
# Therefore, the source for the e2e tests and `make deploy` will be from base.
# Therefore, the source used for the e2e tests and `make deploy` will be from base, rather than the pull request.
# Reference(s):
# - https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target
# - https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target/
# - https://securitylab.github.com/research/github-actions-preventing-pwn-requests/

on:
Expand Down