Get random region for Gardener cluster in backend switching job and check for is-PR-approved #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfaizanse
added
do-not-merge/hold
kyma-bot
added
cla: yes
kyma-bot
added
area/ci
3 tasks
mfaizanse
changed the title
muralov
reviewed
Jan 19, 2024
| @@ -60,6 +58,9 @@ jobs: | |||
| # generate cluster name and export it to Github env for cleanup step to access it. | |||
| export CLUSTER_NAME="${CLUSTER_PREFIX}$(openssl rand -hex 2)" | |||
| echo "CLUSTER_NAME=${CLUSTER_NAME}" >> $GITHUB_ENV | |||
| # set random region for AWS. | |||
| export GARDENER_REGION=$(./scripts/gardener/aws/get_random_region.sh) | |||
| export GARDENER_ZONES="${GARDENER_REGION}a" | |||
There was a problem hiding this comment.
why do we always use zones with the suffix a?
There was a problem hiding this comment.
We are always using the first zone in the region, we do not have any preference for zones.
muralov
reviewed
Jan 19, 2024
| wait-until-build-succeeds: | ||
| runs-on: ubuntu-latest | ||
| needs: is-pr-approved |
There was a problem hiding this comment.
why don't you want to run this if an PR not approved?
There was a problem hiding this comment.
We have quota limits on number of gardener clusters, so we are filtering out to only run on approved PRs so less number of gardener clusters are created at a time.
mfaizanse
removed
the
do-not-merge/hold
muralov
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)