Rely on the NATS cluster connection status when reporting the Eventing CR status #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
marcobebway
force-pushed
the
267-eventing-readiness-based-on-nats-availability
branch
from
e5a8405
to
1a355aa
Compare
marcobebway
added
area/eventing
marcobebway
force-pushed
the
267-eventing-readiness-based-on-nats-availability
branch
2 times, most recently
from
601af6a
to
4edf614
Compare
|
/hold |
kyma-bot
added
the
do-not-merge/hold
|
Remaining tasks:
|
marcobebway
force-pushed
the
267-eventing-readiness-based-on-nats-availability
branch
4 times, most recently
from
31c731c
to
5bfa88a
Compare
marcobebway
force-pushed
the
267-eventing-readiness-based-on-nats-availability
branch
from
5bfa88a
to
874c749
Compare
kyma-bot
added
size/XXL
marcobebway
force-pushed
the
267-eventing-readiness-based-on-nats-availability
branch
from
4eecb1e
to
df439d7
Compare
muralov
reviewed
Jan 26, 2024
| RegisterReconnectHandlerIfNotRegistered(natsio.ConnHandler) | ||
|
|
||
| // RegisterDisconnectErrHandlerIfNotRegistered registers a DisconnectErrHandler only if it was not registered before. | ||
| RegisterDisconnectErrHandlerIfNotRegistered(natsio.ConnErrHandler) |
There was a problem hiding this comment.
(nitpick): Can we shorten the name to RegisterDisconnectErrHandler? The if not registered can be documented.
| ) error { | ||
| // check if the backend was changed. | ||
| if !eventing.IsSpecBackendTypeChanged() { | ||
| if eventingCR.IsPreviousBackendEmpty() || !eventingCR.IsSpecBackendTypeChanged() { |
marcobebway
force-pushed
the
267-eventing-readiness-based-on-nats-availability
branch
from
3195dcb
to
7c9d981
Compare
muralov
approved these changes
Jan 29, 2024
|
/hold cancel |
kyma-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rely on the NATS cluster connection status when reporting the Eventing CR status.
As part of this PR, remove unsupported conditions from the Eventing Status. Because currently we preserve conditions even though it is removed in old releases.
Related issue(s)
in deletion stateresults in eventing-cr inerrorstate #267.