chore: config reload (#348)

kyma-project · Jul 12, 2024 · ee2db67 · ee2db67
1 parent 454ffbf
commit ee2db67
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/cmd/main.go b/cmd/main.go
@@ -18,6 +18,7 @@ package main
 
 import (
 	"flag"
+	"github.com/fsnotify/fsnotify"
 	"os"
 
 	"github.com/elliotchance/pie/v2"
@@ -280,6 +281,15 @@ func main() {
 		Plane(featuretypes.PlaneKcp).
 		Build(ctx)
 
+	go func() {
+		err := cfg.Watch(ctx.Done(), func(_ fsnotify.Event) {
+			cfg.Read()
+		})
+		if err != nil {
+			rootLogger.Error(err, "Error from config watcher")
+		}
+	}()
+
 	if err := mgr.Start(ctx); err != nil {
 		setupLog.Error(err, "problem running manager")
 		os.Exit(1)

diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -117,7 +117,7 @@ func (c *config) Read() {
 	}
 }
 
-func (c *config) Watch(stopCh chan struct{}, onConfigChange func(event fsnotify.Event)) error {
+func (c *config) Watch(stopCh <-chan struct{}, onConfigChange func(event fsnotify.Event)) error {
 	state := &watchedState{}
 
 	// if nil provided, it won't ever be closed, aka watch stopped, make a stub instead

diff --git a/pkg/config/types.go b/pkg/config/types.go
@@ -15,7 +15,7 @@ type Config interface {
 	SourceEnv(fieldPath string, envVarPrefix string)
 	Sensitive(fieldPath string)
 	Read()
-	Watch(stopCh chan struct{}, onConfigChange func(event fsnotify.Event)) error
+	Watch(stopCh <-chan struct{}, onConfigChange func(event fsnotify.Event)) error
 	Bind(fieldPath string, obj any)
 	Json() string
 	PrintJson() string