Skip to content

Commit

Permalink
Correct typos and URLs for GSA#833 constraint re @Gabeblis feedback
Browse files Browse the repository at this point in the history
Co-authored-by: Gabeblis <[email protected]>
  • Loading branch information
aj-stein-gsa and Gabeblis committed Dec 5, 2024
1 parent 871da38 commit 6567519
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
7 changes: 3 additions & 4 deletions src/validations/constraints/fedramp-external-constraints.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,10 @@
<prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/general-concepts/4-expressing-common-fedramp-template-elements-in-oscal/"/>
<message>A FedRAMP document MUST have a marking that defines its data classification.</message>
</expect>
<expect id="oscal-version-matches-fedramp-version" target="oscal-version" level="ERROR"
test="$major-version-valid and $minor-version-valid and $patch-version-valid">
<prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://docs.oasis-open.org/sarif/sarif/v2.1.0"/>
<expect id="oscal-version-matches-fedramp-version" target="oscal-version" test="$major-version-valid and $minor-version-valid and $patch-version-valid" level="ERROR">
<prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/general-concepts/oscal-file-concepts/#oscal-syntax-version"/>
<message>A FedRAMP document SHOULD have an OSCAL version that matches the minimally required version for FedRAMP packages ({$fedramp-required-minimum-version} not {.}).</message>
</expect>
</expect>
</constraints>
</context>
<context>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
test-case:
name: Positive Test for import-profile-has-available-document
name: Positive Test for oscal-version-matches-fedramp-version
description: >-
This test case validates the behavior of constraint import-profile-has-available-document.
This test case validates the behavior of constraint oscal-version-matches-fedramp-version.
Scenario 1 tests: an invalid match below the minimum required version threshold.
Scenario 2 tests: an invalid match above the implied maximum required version threshold, a major version greater than required.
Scenario 3 tests: an invalid match because the fedramp-version prop is missing, so a fallthrough default is required.
Expand Down

0 comments on commit 6567519

Please sign in to comment.