Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move test, update requirements #76

Merged
merged 28 commits into from
Dec 31, 2023
Merged

move test, update requirements #76

merged 28 commits into from
Dec 31, 2023

Conversation

evelynmitchell
Copy link
Contributor

The test was in the wrong directory:
Moved it to the correct tests location.

____________ ERROR collecting zeta/nn/modules/test_dense_connect.py ____________
ImportError while importing test module '/usr/src/zeta/zeta/nn/modules/test_dense_connect.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
zeta/__init__.py:1: in <module>
    from zeta.utils.disable_logging import disable_warnings_and_logs
zeta/utils/__init__.py:10: in <module>
    from zeta.utils.disable_logging import disable_warnings_and_logs
zeta/utils/disable_logging.py:5: in <module>
    import numexpr as ne
E   ModuleNotFoundError: No module named 'numexpr'

@evelynmitchell evelynmitchell changed the title move test_dense_connect to correct dir move test, update requirements Dec 29, 2023
@evelynmitchell
Copy link
Contributor Author

Added numexpr to requirements. Tests now running.

@evelynmitchell
Copy link
Contributor Author

One of the tokenizer tests depended on writing a file. Removed it.

@evelynmitchell
Copy link
Contributor Author

Removed test to fix #77

@evelynmitchell
Copy link
Contributor Author

model/base.py did not raise NotImplemented here, The test was looking for that.

Catching up 20231229 1519
tests/utils/test_absmax.py Fixed Show fixed Hide fixed
tests/utils/test_absmax.py Fixed Show fixed Hide fixed
tests/utils/test_absmax.py Fixed Show fixed Hide fixed
tests/utils/test_absmax.py Fixed Show fixed Hide fixed
"""Test print_main without distribution"""
print_main(message)
captured = capsys.readouterr()
assert captured.out == message + "\n"
captured = capsys.readout()

Check warning

Code scanning / Pylint (reported by Codacy)

Undefined variable 'capsys' Warning test

Undefined variable 'capsys'
captured = capsys.readouterr()
assert captured.out == message + "\n"
captured = capsys.readout()
assert captured.out == message + "\n"

Check warning

Code scanning / Pylint (reported by Codacy)

Exactly one space required before comparison Warning test

Exactly one space required before comparison
"""Test print_main without distribution"""
print_main(message)
captured = capsys.readouterr()
assert captured.out == message + "\n"
captured = capsys.readout()

Check warning

Code scanning / Pylintpython3 (reported by Codacy)

Undefined variable 'capsys' Warning test

Undefined variable 'capsys'
@@ -11,11 +11,11 @@


# Basic Test
def test_print_main_without_dist(message, capsys):
def test_print_main_without_dist(message):

Check notice

Code scanning / Pylintpython3 (reported by Codacy)

Redefining name 'message' from outer scope (line 8) Note test

Redefining name 'message' from outer scope (line 8)
Catching up 202312291935
@evelynmitchell
Copy link
Contributor Author

Fixing tests

Copy link
Owner

@kyegomez kyegomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the base model changes it's supposed to stay as it is

@evelynmitchell
Copy link
Contributor Author

The base model test checks for Not Implemented. If it stays as is, then the test should be removed.

@kyegomez
Copy link
Owner

@evelynmitchell then have them removed so i can accept

@evelynmitchell
Copy link
Contributor Author

Dine

@kyegomez kyegomez merged commit 01f26b7 into kyegomez:master Dec 31, 2023
20 of 37 checks passed
kyegomez added a commit that referenced this pull request Sep 3, 2024
move test, update requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants