Exclude unobtainable SOS encounters

Rather than do backtracking logic to see if the slot can be yielded, don't acknowledge the slot exists if it can't be yielded. See pk3DS commit where we check EscapeRate for the base wild slot prior to adding it to the exported slot list.
kwsch · Oct 10, 2020 · 944c473 · 944c473
1 parent 79f60d2
commit 944c473
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 4 deletions.
diff --git a/PKHeX.Core/Legality/Verifiers/AbilityVerifier.cs b/PKHeX.Core/Legality/Verifiers/AbilityVerifier.cs
@@ -294,10 +294,6 @@ private CheckResult VerifyAbility7(LegalityAnalysis data, IEncounterable enc)
                 bool valid = slot.Area.Type == SlotType.SOS;
                 if (!valid)
                     return GetInvalid(LAbilityMismatchSOS);
-
-                var pi = PersonalTable.USUM[slot.Species];
-                if (pi.EscapeRate == 0) // Can't SOS
-                    return GetInvalid(LAbilityHiddenFail);
             }
             if (Legal.Ban_NoHidden7.Contains(pkm.SpecForm) && pkm.AbilityNumber == 4)
                 return GetInvalid(LAbilityHiddenUnavailable);

diff --git a/PKHeX.Core/Resources/byte/encounter_mn.pkl b/PKHeX.Core/Resources/byte/encounter_mn.pkl
diff --git a/PKHeX.Core/Resources/byte/encounter_sn.pkl b/PKHeX.Core/Resources/byte/encounter_sn.pkl
diff --git a/PKHeX.Core/Resources/byte/encounter_um.pkl b/PKHeX.Core/Resources/byte/encounter_um.pkl
diff --git a/PKHeX.Core/Resources/byte/encounter_us.pkl b/PKHeX.Core/Resources/byte/encounter_us.pkl