Windows Fix Multiple Monitor Mouse Input #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwhat
force-pushed
the
1.3
branch
3 times, most recently
from
42ff6c2
to
22ba8a0
Compare
|
@FaithBeam this pull request is a little out of date - could you please rebase it on top of the 1.3 branch and resolve conflicts? Also, the original pull request contained a couple more commits - could you add them here as well? @kwhat did you have a chance to review this pull request? |
|
@TolikPylypchuk if @kwhat expresses interest in this, I'll update the PR. |
|
Ive looked at this vut i still dont understand why its needed. |
|
It's been a while since I last looked at the code, but libuiohook doesn't calculate the correct coordinates for mouse input when multiple monitors are connected on Windows. One monitor: works This PR fixes multiple monitor mouse input for Windows. |
|
Sorry, I accidentally closed this. Reopening. |
kwhat
force-pushed
the
1.3
branch
3 times, most recently
from
5944f6c
to
987fec0
Compare
kwhat
force-pushed
the
1.3
branch
6 times, most recently
from
99a6851
to
0e34a45
Compare
kwhat
force-pushed
the
1.3
branch
3 times, most recently
from
7d51994
to
90c2248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This PR fixes libuiohook's issue with multi-monitor mouse input and movement for Windows.
Very quickly, this is done by converting the low-level mouse hook coordinates that libuiohook returns to be relative to the virtual desktop. It creates an invisible window and listens for the WM_DISPLAYCHANGE event which is sent whenever a monitor changes position or resolution to get the width and height of monitors in relation to the primary monitor. I wrote some notes and examples here if you want to take a look: https://i.imgur.com/z3vKjtm.png
This video shows a modified demo_hook/post_async with the change. This change does not touch dpi stuff, so the calling application should set something like SetProcessDpiAwareness(PROCESS_PER_MONITOR_DPI_AWARE); to handle monitors that are not 100% scale.
https://youtu.be/YhrC_oLPtRM
The modified program listens for middle mouse button release and sends a right mouse button down and up at the current mouse coordinates.
This is the sample program: https://gist.github.com/FaithBeam/e90bad32fd2fef0c825cfa9c403f9e7b
Should fix #21.