Fixed several issues for X11 #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case if you want just post events without hooks then it lead to usage of xfree86_scancode_table even if evdev available. It leads that keys e.g. VC_UP, VC_DOWN, etc. works incorrectly. 2. Fixed checks for XTestFake functions. According to source code, functions XTestFakeKeyEvent, XTestFakeButtonEvent, XTestFakeMotionEvent always returns 1. Please see https://github.com/freedesktop/xorg-libXtst/blob/master/src/XTest.c
kwhat
force-pushed
the
1.3
branch
3 times, most recently
from
42ff6c2
to
22ba8a0
Compare
kwhat
reviewed
Jun 23, 2023
| @@ -444,6 +444,8 @@ void on_library_load() { | |||
| __FUNCTION__, __LINE__, "XOpenDisplay success."); | |||
| } | |||
|
|
|||
| load_input_helper(); | |||
There was a problem hiding this comment.
Why does this need to run on library load?
kwhat
force-pushed
the
1.3
branch
9 times, most recently
from
99a6851
to
0e34a45
Compare
kwhat
force-pushed
the
1.3
branch
2 times, most recently
from
7d51994
to
90c2248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added call load_input_helper() into on_library_load.
In case if you want just post events without hooks then it lead to usage of xfree86_scancode_table even if evdev available.
It leads that keys e.g. VC_UP, VC_DOWN, etc. works incorrectly.
Fixed checks for XTestFake functions.
According to source code, functions XTestFakeKeyEvent, XTestFakeButtonEvent, XTestFakeMotionEvent always returns 1.
Please see https://github.com/freedesktop/xorg-libXtst/blob/master/src/XTest.c