Skip to content

Commit

Permalink
fix(event:started): duplicate started event was thrown
Browse files Browse the repository at this point in the history
  • Loading branch information
rolljee committed Jul 1, 2024
1 parent 87be8bd commit 3060b35
Show file tree
Hide file tree
Showing 3 changed files with 103 additions and 92 deletions.
174 changes: 98 additions & 76 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,28 +5,68 @@
*.js.map

/index.js
docker/scripts/functional-tests-controller.js
docker/scripts/start-kuzzle-dev.js
docker/scripts/start-kuzzle-test.js
features/support/application/functional-tests-app.js
lib/api/controllers/authController.js
lib/api/controllers/baseController.js
lib/api/controllers/debugController.js
lib/api/openapi/components/document/index.js
lib/api/openapi/components/index.js
lib/api/openapi/components/security/index.js
lib/api/openapi/document/index.js
lib/api/openapi/index.js
lib/api/openapi/openApiGenerator.js
lib/api/openapi/OpenApiManager.js
lib/api/openapi/tools.js
lib/api/openApiGenerator.js
lib/api/request/index.js
lib/api/request/kuzzle-request.js
lib/api/request/kuzzleRequest.js
lib/api/request/requestContext.js
lib/api/request/requestInput.js
lib/api/request/requestResponse.js
lib/cluster/idCardHandler.js
lib/cluster/state.js
lib/config/default.config.js
lib/config/documentEventAliases.js
lib/core/auth/tokenManager.js
lib/core/backend/applicationManager.js
lib/core/backend/backend.js
lib/core/backend/backendCluster.js
lib/core/backend/backendConfig.js
lib/core/backend/backendController.js
lib/core/backend/backendErrors.js
lib/core/backend/backendHook.js
lib/core/backend/backendImport.js
lib/core/backend/backendOpenApi.js
lib/core/backend/backendPipe.js
lib/core/backend/backendPlugin.js
lib/core/backend/backendPlugin.js
lib/core/backend/backendStorage.js
lib/core/backend/backendSubscription.js
lib/core/backend/backendVault.js
lib/core/backend/index.js
lib/core/backend/internalLogger.js
lib/core/shared/sdk/embeddedSdk.js
lib/core/shared/KoncordeWrapper.js
lib/core/cache/cacheDbEnum.js
lib/core/debug/kuzzleDebugger.js
lib/core/plugin/pluginContext.js
lib/api/request/index.js
lib/api/request/kuzzle-request.js
lib/api/request/kuzzleRequest.js
lib/api/request/requestContext.js
lib/api/request/requestInput.js
lib/api/request/requestResponse.js
lib/core/realtime/channel.js
lib/core/realtime/connectionRooms.js
lib/core/realtime/hotelClerk.js
lib/core/realtime/room.js
lib/core/realtime/subscription.js
lib/core/security/profileRepository.js
lib/core/security/tokenRepository.js
lib/core/shared/KoncordeWrapper.js
lib/core/shared/ObjectRepository.js
lib/core/shared/repository.js
lib/core/shared/sdk/embeddedSdk.js
lib/core/shared/sdk/funnelProtocol.js
lib/core/shared/store.js
lib/core/storage/indexCache.js
lib/core/storage/storeScopeEnum.js
lib/kerror/errors/badRequestError.js
lib/kerror/errors/externalServiceError.js
lib/kerror/errors/forbiddenError.js
Expand All @@ -43,91 +83,73 @@ lib/kerror/errors/serviceUnavailableError.js
lib/kerror/errors/sizeLimitError.js
lib/kerror/errors/tooManyRequestsError.js
lib/kerror/errors/unauthorizedError.js
lib/types/index.js
lib/types/Controller.js
lib/types/ControllerDefinition.js
lib/types/Deprecation.js
lib/types/EventHandler.js
lib/types/InternalLogger.js
lib/types/Plugin.js
lib/types/PluginManifest.js
lib/types/RequestPayload.js
lib/types/ResponsePayload.js
lib/types/StrategyDefinition.js
lib/types/Token.js
lib/types/User.js
lib/types/Global.d.ts
lib/types/Global.js
lib/types/storage/Elasticsearch.js
lib/util/interfaces.js
lib/util/mutex.js
lib/util/Inflector.js
lib/util/koncordeCompat.js
lib/util/name-generator.js
features/support/application/functional-tests-app.js
lib/kerror/index.js
lib/kuzzle/kuzzle.js
lib/model/security/profile.js
lib/model/security/role.js
lib/model/security/token.js
lib/core/auth/tokenManager.js
lib/cluster/state.js
lib/core/realtime/hotelClerk.js
lib/types/realtime/RealtimeScope.js
lib/types/realtime/RealtimeUsers.js
lib/core/realtime/channel.js
lib/core/realtime/connectionRooms.js
lib/core/realtime/room.js
lib/core/realtime/subscription.js
lib/types/realtime/RoomList.js
lib/cluster/idCardHandler.js
lib/types/KuzzleDocument.js
lib/core/storage/indexCache.js
lib/api/openApiGenerator.js
lib/api/openapi/document/index.js
lib/api/openapi/tools.js
lib/api/openapi/index.js
lib/util/readYamlFile.js
lib/config/default.config.js
lib/types/PasswordPolicy.js
lib/types/ProfileDefinition.js
lib/types/RoleDefinition.js
lib/model/security/user.js
lib/service/storage/elasticsearch.js
lib/types/ClientConnection.js
lib/types/config/DumpConfiguration.js
lib/types/config/HttpConfiguration.js
lib/types/config/internalCache/InternalCacheRedisConfiguration.js
lib/types/config/KuzzleConfiguration.js
lib/types/config/LimitsConfiguration.js
lib/types/config/PluginsConfiguration.js
lib/types/config/publicCache/PublicCacheRedisConfiguration.js
lib/types/config/SecurityConfiguration.js
lib/types/config/ServerConfiguration.js
lib/types/config/ServicesConfiguration.js
lib/types/config/storageEngine/StorageEngineElasticsearchConfiguration.js
lib/types/config/StorageService/StorageServiceElasticsearchConfiguration.js
lib/types/config/internalCache/InternalCacheRedisConfiguration.js
lib/types/config/publicCache/PublicCacheRedisConfiguration.js
lib/api/openapi/OpenApiManager.js
lib/api/openapi/components/document/index.js
lib/api/openapi/components/index.js
lib/api/openapi/openApiGenerator.js
lib/core/backend/backendErrors.js
lib/core/backend/backendOpenApi.js
lib/core/security/profileRepository.js
lib/core/shared/sdk/funnelProtocol.js
lib/kerror/index.js
lib/model/security/profile.js
lib/model/security/role.js
lib/model/security/user.js
lib/types/Controller.js
lib/types/ControllerDefinition.js
lib/types/ControllerRights.js
lib/types/DebugModule.js
lib/types/Deprecation.js
lib/types/errors/ErrorDefinition.js
lib/types/errors/ErrorDomains.js
lib/types/EventHandler.js
lib/types/events/EventGenericDocument.js
lib/types/events/EventProtocol.js
lib/types/Global.d.ts
lib/types/Global.js
lib/types/HttpMessage.js
lib/types/HttpStream.js
lib/types/index.js
lib/types/InternalLogger.js
lib/types/Kuzzle.js
lib/types/KuzzleDocument.js
lib/types/OpenApiDefinition.js
lib/types/PasswordPolicy.js
lib/types/Plugin.js
lib/types/PluginManifest.js
lib/types/Policy.js
lib/types/PolicyRestrictions.js
lib/types/ProfileDefinition.js
lib/types/realtime/RealtimeScope.js
lib/types/realtime/RealtimeUsers.js
lib/types/realtime/RoomList.js
lib/types/RequestPayload.js
lib/types/ResponsePayload.js
lib/types/RoleDefinition.js
lib/types/shared/StoreCollectionsDefinition.js
lib/types/storage/Elasticsearch.js
lib/types/StrategyDefinition.js
lib/types/Target.js
lib/types/config/storageEngine/StorageEngineElasticsearchConfiguration.js
lib/types/errors/ErrorDefinition.js
lib/types/errors/ErrorDomains.js
lib/types/Token.js
lib/types/User.js
lib/util/array.js
lib/util/async.js
lib/util/bufferedPassThrough.js
lib/util/crypto.js
lib/util/dump-collection.js
lib/api/controllers/debugController.js
lib/api/openapi/components/security/index.js
lib/config/documentEventAliases.js
lib/service/storage/elasticsearch.js
lib/types/DebugModule.js
lib/util/time.js
lib/util/async.js
lib/util/esRequest.js
lib/util/Inflector.js
lib/util/interfaces.js
lib/util/koncordeCompat.js
lib/util/mutex.js
lib/util/name-generator.js
lib/util/readYamlFile.js
lib/util/time.js
11 changes: 5 additions & 6 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ kuzzle-*.tgz
docker/scripts/functional-tests-controller.js
docker/scripts/start-kuzzle-dev.js
docker/scripts/start-kuzzle-test.js
features-sdk/support/application/functional-tests-app.js
features/support/application/functional-tests-app.js
lib/api/controllers/authController.js
lib/api/controllers/baseController.js
lib/api/controllers/debugController.js
Expand All @@ -96,7 +96,6 @@ lib/api/openapi/openApiGenerator.js
lib/api/openapi/OpenApiManager.js
lib/api/openapi/tools.js
lib/api/openApiGenerator.js
lib/api/request/*.js
lib/api/request/index.js
lib/api/request/kuzzle-request.js
lib/api/request/kuzzleRequest.js
Expand All @@ -105,7 +104,6 @@ lib/api/request/requestInput.js
lib/api/request/requestResponse.js
lib/cluster/idCardHandler.js
lib/cluster/state.js
lib/cluster/workers/IDCardRenewer.js
lib/config/default.config.js
lib/config/documentEventAliases.js
lib/core/auth/tokenManager.js
Expand All @@ -120,6 +118,7 @@ lib/core/backend/backendImport.js
lib/core/backend/backendOpenApi.js
lib/core/backend/backendPipe.js
lib/core/backend/backendPlugin.js
lib/core/backend/backendPlugin.js
lib/core/backend/backendStorage.js
lib/core/backend/backendSubscription.js
lib/core/backend/backendVault.js
Expand All @@ -137,12 +136,12 @@ lib/core/security/profileRepository.js
lib/core/security/tokenRepository.js
lib/core/shared/KoncordeWrapper.js
lib/core/shared/ObjectRepository.js
lib/core/shared/repository.js
lib/core/shared/sdk/embeddedSdk.js
lib/core/shared/sdk/funnelProtocol.js
lib/core/shared/store.js
lib/core/storage/indexCache.js
lib/core/storage/storeScopeEnum.js
lib/kerror/errors/*.js
lib/kerror/errors/badRequestError.js
lib/kerror/errors/externalServiceError.js
lib/kerror/errors/forbiddenError.js
Expand Down Expand Up @@ -186,7 +185,6 @@ lib/types/DebugModule.js
lib/types/Deprecation.js
lib/types/errors/ErrorDefinition.js
lib/types/errors/ErrorDomains.js
lib/types/storage/Elasticsearch.js
lib/types/EventHandler.js
lib/types/events/EventGenericDocument.js
lib/types/events/EventProtocol.js
Expand All @@ -212,6 +210,7 @@ lib/types/RequestPayload.js
lib/types/ResponsePayload.js
lib/types/RoleDefinition.js
lib/types/shared/StoreCollectionsDefinition.js
lib/types/storage/Elasticsearch.js
lib/types/StrategyDefinition.js
lib/types/Target.js
lib/types/Token.js
Expand All @@ -228,4 +227,4 @@ lib/util/koncordeCompat.js
lib/util/mutex.js
lib/util/name-generator.js
lib/util/readYamlFile.js
lib/util/time.js
lib/util/time.js
10 changes: 0 additions & 10 deletions lib/core/backend/backend.ts
Original file line number Diff line number Diff line change
Expand Up @@ -251,16 +251,6 @@ export class Backend {
writable: true,
});

/**
* Set the "started" property in this event so developers can use runtime
* features in pipes/hooks attached to this event.
*/
this._pipes["kuzzle:state:ready"] = [
async () => {
this.started = true;
},
];

try {
const info = JSON.parse(fs.readFileSync("./package.json", "utf8"));
this.version = info.version;
Expand Down

0 comments on commit 3060b35

Please sign in to comment.