Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(device): device creation apply default metadata #378

Open
wants to merge 1 commit into
base: 2-dev
Choose a base branch
from
Open

fix(device): device creation apply default metadata #378

wants to merge 1 commit into from

Conversation

inkedsquid
Copy link
Contributor

What does this PR do ?

This PR adds the logic necessary to replace undefined metadata with the default one defined in the device model.

How should this be manually tested?

  • Step 1 : Create or choose a device model with default metadata
  • Step 2 : Create one device from this model without defining metadata
  • Step 3 : Get the device and check if the metadata gets the default values

@inkedsquid inkedsquid self-assigned this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afondard afondard afondard approved these changes

Assignees

@inkedsquid inkedsquid

Labels
2.4.1 changelog:bug-fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inkedsquid @afondard @etrousset