Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor scalar function constructor #4666

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Dec 24, 2024

Description

This is a followed up PR of #4664. The goal is to reduce the number of constructors for scalar function.

Fixes # (issue)

Contributor agreement

@andyfengHKU andyfengHKU force-pushed the refactor-scalar-function-constructor branch from d5cab1f to cf4b548 Compare December 24, 2024 06:37
Copy link

Benchmark Result

Master commit hash: 3e87d45512dde77dcc8cd51bda03a31d6106628f
Branch commit hash: 4f9bae57d22b92754350938ac845d97ca8011c03

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 656.21 645.75 10.45 (1.62%)
aggregation q28 11248.98 11473.45 -224.47 (-1.96%)
filter q14 134.20 127.82 6.38 (4.99%)
filter q15 139.18 128.87 10.31 (8.00%)
filter q16 313.62 308.38 5.24 (1.70%)
filter q17 458.67 453.77 4.90 (1.08%)
filter q18 1984.92 1975.41 9.51 (0.48%)
filter zonemap-node 96.43 89.92 6.51 (7.24%)
filter zonemap-node-lhs-cast 98.36 88.41 9.95 (11.26%)
filter zonemap-node-null 96.09 85.14 10.95 (12.86%)
filter zonemap-rel 5726.78 5711.36 15.42 (0.27%)
fixed_size_expr_evaluator q07 588.98 582.45 6.53 (1.12%)
fixed_size_expr_evaluator q08 823.99 816.42 7.58 (0.93%)
fixed_size_expr_evaluator q09 817.16 803.34 13.82 (1.72%)
fixed_size_expr_evaluator q10 255.16 239.42 15.74 (6.58%)
fixed_size_expr_evaluator q11 246.62 228.80 17.82 (7.79%)
fixed_size_expr_evaluator q12 241.66 229.36 12.30 (5.36%)
fixed_size_expr_evaluator q13 1481.94 1492.28 -10.34 (-0.69%)
fixed_size_seq_scan q23 127.27 114.42 12.85 (11.23%)
join q29 624.29 598.03 26.26 (4.39%)
join q30 1550.79 1557.87 -7.08 (-0.45%)
join q31 4.36 4.42 -0.06 (-1.43%)
join SelectiveTwoHopJoin 54.46 51.87 2.59 (4.99%)
ldbc_snb_ic q35 2626.16 2636.22 -10.07 (-0.38%)
ldbc_snb_ic q36 552.80 574.86 -22.05 (-3.84%)
ldbc_snb_is q32 6.45 6.53 -0.08 (-1.29%)
ldbc_snb_is q33 14.59 14.48 0.11 (0.78%)
ldbc_snb_is q34 0.89 1.13 -0.25 (-21.82%)
multi-rel multi-rel-large-scan 1366.55 1300.57 65.98 (5.07%)
multi-rel multi-rel-lookup 5.63 9.78 -4.15 (-42.46%)
multi-rel multi-rel-small-scan 94.77 76.49 18.29 (23.91%)
order_by q25 142.84 143.04 -0.20 (-0.14%)
order_by q26 472.83 458.60 14.23 (3.10%)
order_by q27 1500.96 1479.69 21.27 (1.44%)
recursive_join recursive-join-bidirection 271.70 291.75 -20.05 (-6.87%)
recursive_join recursive-join-dense 7433.89 7046.94 386.95 (5.49%)
recursive_join recursive-join-path 24023.90 23755.79 268.11 (1.13%)
recursive_join recursive-join-sparse 15034.55 14584.63 449.92 (3.08%)
recursive_join recursive-join-trail 7357.56 7362.74 -5.18 (-0.07%)
scan_after_filter q01 183.54 176.94 6.60 (3.73%)
scan_after_filter q02 171.14 157.33 13.81 (8.78%)
shortest_path_ldbc100 q37 91.28 88.72 2.56 (2.88%)
shortest_path_ldbc100 q38 310.01 332.31 -22.30 (-6.71%)
shortest_path_ldbc100 q39 62.44 63.13 -0.68 (-1.08%)
shortest_path_ldbc100 q40 453.56 456.86 -3.30 (-0.72%)
var_size_expr_evaluator q03 2094.46 2078.43 16.04 (0.77%)
var_size_expr_evaluator q04 2234.46 2257.56 -23.10 (-1.02%)
var_size_expr_evaluator q05 2754.44 2550.53 203.91 (7.99%)
var_size_expr_evaluator q06 1349.28 1349.02 0.26 (0.02%)
var_size_seq_scan q19 1468.90 1464.33 4.57 (0.31%)
var_size_seq_scan q20 2659.06 2631.34 27.72 (1.05%)
var_size_seq_scan q21 2323.78 2284.91 38.87 (1.70%)
var_size_seq_scan q22 129.54 128.60 0.94 (0.73%)

Copy link
Contributor

@ray6080 ray6080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the PR description? Let's not use the template as it is.
Why do we choose to move bindFunc outside of constructor?

@andyfengHKU andyfengHKU merged commit c14b6d4 into master Dec 27, 2024
@andyfengHKU andyfengHKU deleted the refactor-scalar-function-constructor branch December 27, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants