Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor table function constructor #4664

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

andyfengHKU
Copy link
Contributor

Description

As we introduce more member fields in table function, the constructor is getting very bulky. I'm removing constructors and let each function sets its own field.

Fixes # (issue)

Contributor agreement

@andyfengHKU andyfengHKU force-pushed the refactor-table-func-constructor branch from 6d747bb to 36208e5 Compare December 23, 2024 08:47
@andyfengHKU andyfengHKU force-pushed the refactor-table-func-constructor branch from e7f60b7 to 8b3b9b5 Compare December 23, 2024 10:57
Copy link

Benchmark Result

Master commit hash: 970f5c43e58661c004038fd0a07e18f5fc3e1dcb
Branch commit hash: 32a29152f688a6a5882a6f278cd205586304728a

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 647.27 656.85 -9.58 (-1.46%)
aggregation q28 11815.85 11744.63 71.22 (0.61%)
filter q14 125.57 125.64 -0.07 (-0.05%)
filter q15 123.84 129.02 -5.18 (-4.01%)
filter q16 305.40 302.46 2.94 (0.97%)
filter q17 444.51 447.10 -2.59 (-0.58%)
filter q18 1964.37 1963.15 1.22 (0.06%)
filter zonemap-node 88.48 87.08 1.40 (1.60%)
filter zonemap-node-lhs-cast 88.51 87.37 1.14 (1.31%)
filter zonemap-node-null 84.86 N/A N/A
filter zonemap-rel 5445.95 5464.53 -18.57 (-0.34%)
fixed_size_expr_evaluator q07 571.74 584.23 -12.49 (-2.14%)
fixed_size_expr_evaluator q08 803.10 813.72 -10.61 (-1.30%)
fixed_size_expr_evaluator q09 802.66 817.39 -14.74 (-1.80%)
fixed_size_expr_evaluator q10 236.88 240.40 -3.52 (-1.46%)
fixed_size_expr_evaluator q11 231.29 233.31 -2.02 (-0.87%)
fixed_size_expr_evaluator q12 225.81 231.42 -5.61 (-2.43%)
fixed_size_expr_evaluator q13 1467.02 1484.51 -17.49 (-1.18%)
fixed_size_seq_scan q23 112.60 112.83 -0.23 (-0.20%)
join q29 644.98 613.93 31.06 (5.06%)
join q30 1538.30 1545.78 -7.48 (-0.48%)
join q31 4.30 6.39 -2.10 (-32.78%)
join SelectiveTwoHopJoin 55.83 47.77 8.05 (16.86%)
ldbc_snb_ic q35 2635.45 2603.36 32.09 (1.23%)
ldbc_snb_ic q36 541.85 558.12 -16.27 (-2.91%)
ldbc_snb_is q32 5.83 5.18 0.65 (12.45%)
ldbc_snb_is q33 10.31 12.15 -1.83 (-15.10%)
ldbc_snb_is q34 1.26 1.08 0.18 (16.65%)
multi-rel multi-rel-large-scan 1315.39 1216.57 98.81 (8.12%)
multi-rel multi-rel-lookup 6.28 30.38 -24.11 (-79.34%)
multi-rel multi-rel-small-scan 97.47 74.65 22.82 (30.58%)
order_by q25 140.76 134.91 5.85 (4.33%)
order_by q26 457.35 456.55 0.80 (0.18%)
order_by q27 1479.68 1478.33 1.35 (0.09%)
recursive_join recursive-join-bidirection 289.32 260.87 28.45 (10.91%)
recursive_join recursive-join-dense 7351.42 5001.85 2349.57 (46.97%)
recursive_join recursive-join-path 23932.78 23387.10 545.68 (2.33%)
recursive_join recursive-join-sparse 14695.69 13850.58 845.11 (6.10%)
recursive_join recursive-join-trail 7349.77 5044.11 2305.66 (45.71%)
scan_after_filter q01 174.67 176.81 -2.14 (-1.21%)
scan_after_filter q02 160.01 161.55 -1.53 (-0.95%)
shortest_path_ldbc100 q37 87.90 95.79 -7.89 (-8.24%)
shortest_path_ldbc100 q38 363.85 355.75 8.10 (2.28%)
shortest_path_ldbc100 q39 62.21 57.57 4.63 (8.05%)
shortest_path_ldbc100 q40 452.42 433.75 18.67 (4.30%)
var_size_expr_evaluator q03 2087.32 2142.09 -54.77 (-2.56%)
var_size_expr_evaluator q04 2236.78 2304.84 -68.06 (-2.95%)
var_size_expr_evaluator q05 2548.68 2634.66 -85.97 (-3.26%)
var_size_expr_evaluator q06 1339.94 1353.87 -13.93 (-1.03%)
var_size_seq_scan q19 1469.69 1488.09 -18.40 (-1.24%)
var_size_seq_scan q20 2349.42 2420.47 -71.05 (-2.94%)
var_size_seq_scan q21 2282.62 2300.22 -17.60 (-0.77%)
var_size_seq_scan q22 128.14 128.75 -0.61 (-0.47%)

@andyfengHKU andyfengHKU merged commit 3e87d45 into master Dec 23, 2024
@andyfengHKU andyfengHKU deleted the refactor-table-func-constructor branch December 23, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants