Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include for std::optional in extension #4653

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

acquamarin
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.51%. Comparing base (970f5c4) to head (58398b6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4653   +/-   ##
=======================================
  Coverage   86.50%   86.51%           
=======================================
  Files        1369     1369           
  Lines       57955    57955           
  Branches     7203     7204    +1     
=======================================
+ Hits        50136    50138    +2     
+ Misses       7652     7650    -2     
  Partials      167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark Result

Master commit hash: c46eec1f7a168ec7d541219adb38136c0c5019b0
Branch commit hash: bf27f236a272c449e7aa3b052d5a459d231e9ada

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 642.92 643.11 -0.19 (-0.03%)
aggregation q28 11857.96 11654.01 203.95 (1.75%)
copy node-Comment 71884.95 N/A N/A
copy node-Forum 5415.35 N/A N/A
copy node-Organisation 1216.01 N/A N/A
copy node-Person 2072.25 N/A N/A
copy node-Place 1167.76 N/A N/A
copy node-Post 31114.21 N/A N/A
copy node-Tag 1246.69 N/A N/A
copy node-Tagclass 1133.39 N/A N/A
copy rel-comment-hasCreator 55739.49 N/A N/A
copy rel-comment-hasTag 88470.74 N/A N/A
copy rel-comment-isLocatedIn 70252.25 N/A N/A
copy rel-containerOf 15158.32 N/A N/A
copy rel-forum-hasTag 3970.12 N/A N/A
copy rel-hasInterest 3056.93 N/A N/A
copy rel-hasMember 53260.12 N/A N/A
copy rel-hasModerator 1260.40 N/A N/A
copy rel-hasType 223.03 N/A N/A
copy rel-isPartOf 242.10 N/A N/A
copy rel-isSubclassOf 363.54 N/A N/A
copy rel-knows 6303.88 N/A N/A
copy rel-likes-comment 86360.84 N/A N/A
copy rel-likes-post 32644.53 N/A N/A
copy rel-organisation-isLocatedIn 234.48 N/A N/A
copy rel-person-isLocatedIn 423.63 N/A N/A
copy rel-post-hasCreator 14573.93 N/A N/A
copy rel-post-hasTag 23502.17 N/A N/A
copy rel-post-isLocatedIn 18479.04 N/A N/A
copy rel-replyOf-comment 46944.58 N/A N/A
copy rel-replyOf-post 36452.42 N/A N/A
copy rel-studyAt 516.47 N/A N/A
copy rel-workAt 729.18 N/A N/A
filter q14 125.26 124.81 0.45 (0.36%)
filter q15 132.71 126.02 6.69 (5.31%)
filter q16 304.95 303.17 1.78 (0.59%)
filter q17 446.21 444.24 1.97 (0.44%)
filter q18 1972.53 1969.39 3.14 (0.16%)
filter zonemap-node 86.32 85.87 0.45 (0.52%)
filter zonemap-node-lhs-cast 87.73 86.22 1.51 (1.75%)
filter zonemap-rel 5734.89 5755.70 -20.81 (-0.36%)
fixed_size_expr_evaluator q07 572.28 572.79 -0.51 (-0.09%)
fixed_size_expr_evaluator q08 799.53 803.01 -3.48 (-0.43%)
fixed_size_expr_evaluator q09 803.53 802.80 0.74 (0.09%)
fixed_size_expr_evaluator q10 235.45 238.65 -3.20 (-1.34%)
fixed_size_expr_evaluator q11 228.79 231.30 -2.51 (-1.08%)
fixed_size_expr_evaluator q12 227.68 225.51 2.17 (0.96%)
fixed_size_expr_evaluator q13 1464.48 1453.76 10.72 (0.74%)
fixed_size_seq_scan q23 114.45 112.87 1.58 (1.40%)
join q29 605.50 614.09 -8.59 (-1.40%)
join q30 1565.94 1460.61 105.33 (7.21%)
join q31 4.68 4.41 0.27 (6.24%)
join SelectiveTwoHopJoin 56.46 52.19 4.26 (8.17%)
ldbc_snb_ic q35 2590.27 2631.05 -40.78 (-1.55%)
ldbc_snb_ic q36 553.10 528.84 24.26 (4.59%)
ldbc_snb_is q32 6.32 4.78 1.54 (32.17%)
ldbc_snb_is q33 15.00 12.03 2.96 (24.63%)
ldbc_snb_is q34 1.23 1.03 0.19 (18.58%)
multi-rel multi-rel-large-scan 1228.08 1212.49 15.59 (1.29%)
multi-rel multi-rel-lookup 28.94 19.58 9.37 (47.85%)
multi-rel multi-rel-small-scan 63.76 56.02 7.74 (13.82%)
order_by q25 129.74 130.28 -0.54 (-0.42%)
order_by q26 452.29 448.74 3.55 (0.79%)
order_by q27 1492.33 1465.40 26.92 (1.84%)
recursive_join recursive-join-bidirection 301.01 278.17 22.85 (8.21%)
recursive_join recursive-join-dense 7409.53 7479.45 -69.92 (-0.93%)
recursive_join recursive-join-path 23772.76 23789.32 -16.57 (-0.07%)
recursive_join recursive-join-sparse 14726.49 14370.78 355.70 (2.48%)
recursive_join recursive-join-trail 7320.09 7407.18 -87.09 (-1.18%)
scan_after_filter q01 171.32 167.95 3.36 (2.00%)
scan_after_filter q02 156.66 153.71 2.95 (1.92%)
shortest_path_ldbc100 q37 81.65 86.94 -5.29 (-6.08%)
shortest_path_ldbc100 q38 262.81 302.98 -40.17 (-13.26%)
shortest_path_ldbc100 q39 58.01 56.64 1.37 (2.42%)
shortest_path_ldbc100 q40 291.49 354.84 -63.35 (-17.85%)
var_size_expr_evaluator q03 2118.12 2076.41 41.71 (2.01%)
var_size_expr_evaluator q04 2288.17 2245.55 42.61 (1.90%)
var_size_expr_evaluator q05 2574.55 2701.70 -127.15 (-4.71%)
var_size_expr_evaluator q06 1342.83 1346.45 -3.62 (-0.27%)
var_size_seq_scan q19 1488.33 1464.94 23.39 (1.60%)
var_size_seq_scan q20 2684.71 2714.59 -29.87 (-1.10%)
var_size_seq_scan q21 2295.56 2288.51 7.05 (0.31%)
var_size_seq_scan q22 128.31 125.03 3.28 (2.63%)

@acquamarin acquamarin merged commit 3ba9892 into master Dec 19, 2024
25 checks passed
@acquamarin acquamarin deleted the fix-duckdb-include branch December 19, 2024 04:57
ray6080 pushed a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants