Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove offset from table func #4648

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

andyfengHKU
Copy link
Contributor

@andyfengHKU andyfengHKU commented Dec 18, 2024

Description

See title

Fixes # (issue)

Contributor agreement

@andyfengHKU andyfengHKU requested a review from ray6080 December 18, 2024 05:38
@andyfengHKU andyfengHKU force-pushed the remove-offset-from-table-func branch from 232a17e to c91579c Compare December 18, 2024 06:40
Copy link

Benchmark Result

Master commit hash: c46eec1f7a168ec7d541219adb38136c0c5019b0
Branch commit hash: 3f0834f611253b3c252fcbc06b5da9ee60b7847d

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 643.52 643.11 0.41 (0.06%)
aggregation q28 11285.17 11654.01 -368.84 (-3.16%)
filter q14 126.74 124.81 1.93 (1.54%)
filter q15 125.54 126.02 -0.48 (-0.38%)
filter q16 304.34 303.17 1.17 (0.39%)
filter q17 444.48 444.24 0.24 (0.05%)
filter q18 1963.19 1969.39 -6.20 (-0.31%)
filter zonemap-node 86.62 85.87 0.75 (0.87%)
filter zonemap-node-lhs-cast 86.19 86.22 -0.03 (-0.03%)
filter zonemap-rel 5724.12 5755.70 -31.57 (-0.55%)
fixed_size_expr_evaluator q07 571.32 572.79 -1.46 (-0.26%)
fixed_size_expr_evaluator q08 805.45 803.01 2.44 (0.30%)
fixed_size_expr_evaluator q09 804.47 802.80 1.67 (0.21%)
fixed_size_expr_evaluator q10 238.60 238.65 -0.05 (-0.02%)
fixed_size_expr_evaluator q11 230.95 231.30 -0.34 (-0.15%)
fixed_size_expr_evaluator q12 229.27 225.51 3.76 (1.67%)
fixed_size_expr_evaluator q13 1456.57 1453.76 2.81 (0.19%)
fixed_size_seq_scan q23 115.94 112.87 3.07 (2.72%)
join q29 618.85 614.09 4.76 (0.78%)
join q30 1540.11 1460.61 79.50 (5.44%)
join q31 4.54 4.41 0.13 (2.96%)
join SelectiveTwoHopJoin 49.98 52.19 -2.21 (-4.23%)
ldbc_snb_ic q35 2588.16 2631.05 -42.89 (-1.63%)
ldbc_snb_ic q36 549.85 528.84 21.01 (3.97%)
ldbc_snb_is q32 5.33 4.78 0.55 (11.59%)
ldbc_snb_is q33 12.39 12.03 0.35 (2.94%)
ldbc_snb_is q34 1.17 1.03 0.13 (12.94%)
multi-rel multi-rel-large-scan 1203.79 1212.49 -8.70 (-0.72%)
multi-rel multi-rel-lookup 12.70 19.58 -6.88 (-35.13%)
multi-rel multi-rel-small-scan 91.82 56.02 35.80 (63.91%)
order_by q25 130.76 130.28 0.48 (0.37%)
order_by q26 452.63 448.74 3.89 (0.87%)
order_by q27 1483.41 1465.40 18.00 (1.23%)
recursive_join recursive-join-bidirection 289.29 278.17 11.12 (4.00%)
recursive_join recursive-join-dense 7414.91 7479.45 -64.54 (-0.86%)
recursive_join recursive-join-path 23979.73 23789.32 190.41 (0.80%)
recursive_join recursive-join-sparse 14815.24 14370.78 444.46 (3.09%)
recursive_join recursive-join-trail 7370.19 7407.18 -36.99 (-0.50%)
scan_after_filter q01 173.37 167.95 5.42 (3.23%)
scan_after_filter q02 155.23 153.71 1.52 (0.99%)
shortest_path_ldbc100 q37 93.40 86.94 6.46 (7.43%)
shortest_path_ldbc100 q38 332.25 302.98 29.27 (9.66%)
shortest_path_ldbc100 q39 63.63 56.64 6.99 (12.34%)
shortest_path_ldbc100 q40 475.80 354.84 120.96 (34.09%)
var_size_expr_evaluator q03 2093.85 2076.41 17.43 (0.84%)
var_size_expr_evaluator q04 2290.99 2245.55 45.44 (2.02%)
var_size_expr_evaluator q05 2590.54 2701.70 -111.15 (-4.11%)
var_size_expr_evaluator q06 1346.30 1346.45 -0.15 (-0.01%)
var_size_seq_scan q19 1489.47 1464.94 24.53 (1.67%)
var_size_seq_scan q20 2709.50 2714.59 -5.09 (-0.19%)
var_size_seq_scan q21 2292.83 2288.51 4.33 (0.19%)
var_size_seq_scan q22 129.05 125.03 4.02 (3.22%)

@andyfengHKU andyfengHKU merged commit 970f5c4 into master Dec 18, 2024
@andyfengHKU andyfengHKU deleted the remove-offset-from-table-func branch December 18, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants