Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement get_keys function in fts #4647

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Implement get_keys function in fts #4647

merged 4 commits into from
Dec 18, 2024

Conversation

acquamarin
Copy link
Collaborator

Description

Please include a summary of the changes and the related issue (if applicable). Please also include
relevant motivation and context.

Fixes # (issue)

Contributor agreement

@acquamarin acquamarin changed the title Get keys Implement get_keys function in fts Dec 18, 2024
Copy link

Benchmark Result

Master commit hash: 109012e08f4fb43a8a1605c0065fb32d085381db
Branch commit hash: c2817b2eba7bef6badb4165065fb6e9d98603709

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 644.67 644.42 0.24 (0.04%)
aggregation q28 11343.72 11074.35 269.37 (2.43%)
filter q14 126.50 125.33 1.18 (0.94%)
filter q15 128.99 126.98 2.01 (1.59%)
filter q16 302.58 302.58 0.00 (0.00%)
filter q17 443.59 445.66 -2.07 (-0.46%)
filter q18 1967.47 1998.87 -31.39 (-1.57%)
filter zonemap-node 86.29 89.75 -3.46 (-3.86%)
filter zonemap-node-lhs-cast 86.42 88.09 -1.67 (-1.90%)
filter zonemap-rel 5696.00 5725.58 -29.59 (-0.52%)
fixed_size_expr_evaluator q07 573.04 570.59 2.45 (0.43%)
fixed_size_expr_evaluator q08 802.77 801.41 1.36 (0.17%)
fixed_size_expr_evaluator q09 798.97 800.11 -1.14 (-0.14%)
fixed_size_expr_evaluator q10 237.07 235.47 1.60 (0.68%)
fixed_size_expr_evaluator q11 229.91 227.36 2.55 (1.12%)
fixed_size_expr_evaluator q12 224.48 225.69 -1.21 (-0.54%)
fixed_size_expr_evaluator q13 1457.81 1454.10 3.71 (0.26%)
fixed_size_seq_scan q23 111.73 109.85 1.88 (1.71%)
join q29 580.52 591.34 -10.82 (-1.83%)
join q30 1638.15 1452.69 185.47 (12.77%)
join q31 3.56 4.46 -0.91 (-20.33%)
join SelectiveTwoHopJoin 51.14 53.96 -2.82 (-5.22%)
ldbc_snb_ic q35 2623.71 2557.10 66.61 (2.61%)
ldbc_snb_ic q36 531.44 582.96 -51.52 (-8.84%)
ldbc_snb_is q32 6.38 5.35 1.03 (19.24%)
ldbc_snb_is q33 12.76 11.27 1.49 (13.23%)
ldbc_snb_is q34 1.20 1.09 0.12 (10.60%)
multi-rel multi-rel-large-scan 1226.58 1395.96 -169.38 (-12.13%)
multi-rel multi-rel-lookup 20.29 16.80 3.49 (20.78%)
multi-rel multi-rel-small-scan 91.63 107.47 -15.84 (-14.74%)
order_by q25 131.81 127.60 4.21 (3.30%)
order_by q26 446.20 448.19 -1.99 (-0.44%)
order_by q27 1463.52 1481.08 -17.56 (-1.19%)
recursive_join recursive-join-bidirection 317.94 284.88 33.06 (11.60%)
recursive_join recursive-join-dense 7449.05 7432.96 16.09 (0.22%)
recursive_join recursive-join-path 23749.13 23874.06 -124.92 (-0.52%)
recursive_join recursive-join-sparse 14468.51 14362.64 105.87 (0.74%)
recursive_join recursive-join-trail 7401.48 7368.60 32.88 (0.45%)
scan_after_filter q01 169.45 170.81 -1.37 (-0.80%)
scan_after_filter q02 155.94 155.16 0.78 (0.50%)
shortest_path_ldbc100 q37 86.43 94.48 -8.05 (-8.52%)
shortest_path_ldbc100 q38 367.67 354.90 12.77 (3.60%)
shortest_path_ldbc100 q39 62.36 54.07 8.29 (15.33%)
shortest_path_ldbc100 q40 415.68 458.51 -42.83 (-9.34%)
var_size_expr_evaluator q03 2064.83 2122.09 -57.26 (-2.70%)
var_size_expr_evaluator q04 2236.47 2278.53 -42.06 (-1.85%)
var_size_expr_evaluator q05 2701.62 2557.40 144.22 (5.64%)
var_size_expr_evaluator q06 1340.86 1348.40 -7.54 (-0.56%)
var_size_seq_scan q19 1467.70 1482.42 -14.72 (-0.99%)
var_size_seq_scan q20 2708.25 2690.52 17.73 (0.66%)
var_size_seq_scan q21 2301.98 2301.68 0.30 (0.01%)
var_size_seq_scan q22 125.89 128.06 -2.17 (-1.69%)

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.52%. Comparing base (109012e) to head (7ea4176).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/planner/plan/plan_read.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4647   +/-   ##
=======================================
  Coverage   86.51%   86.52%           
=======================================
  Files        1369     1369           
  Lines       57983    57983           
  Branches     7209     7208    -1     
=======================================
+ Hits        50166    50167    +1     
+ Misses       7649     7648    -1     
  Partials      168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyfengHKU andyfengHKU merged commit c46eec1 into master Dec 18, 2024
24 of 25 checks passed
@andyfengHKU andyfengHKU deleted the get-keys branch December 18, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants