Add null checks to zone map #4642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royi-luo
force-pushed
the
royi/zone-map-add-exprs
branch
from
cbebd92 to
4dd4a75
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4642 +/- ##
=======================================
Coverage 86.51% 86.51%
=======================================
Files 1369 1372 +3
Lines 57955 57996 +41
Branches 7204 7209 +5
=======================================
+ Hits 50138 50176 +38
- Misses 7650 7652 +2
- Partials 167 168 +1 ☔ View full report in Codecov by Sentry. |
Benchmark ResultMaster commit hash:
|
Benchmark ResultMaster commit hash:
|
royi-luo
commented
Dec 17, 2024
| @@ -18,9 +18,10 @@ class KUZU_API ColumnPredicateSet { | |||
| void addPredicate(std::unique_ptr<ColumnPredicate> predicate) { | |||
| predicates.push_back(std::move(predicate)); | |||
| } | |||
| void tryAddPredicate(const binder::Expression& column, const binder::Expression& predicate); | |||
royi-luo
commented
Dec 17, 2024
| @@ -180,21 +181,30 @@ static void updateInMemoryStats(ColumnChunkStats& stats, const ValueVector& valu | |||
| uint64_t offset = 0, uint64_t numValues = std::numeric_limits<uint64_t>::max()) { | |||
| const auto physicalType = values.dataType.getPhysicalType(); | |||
| const auto numValuesToCheck = std::min(numValues, values.state->getSelSize()); | |||
| stats.update(values.getData(), offset, numValuesToCheck, physicalType); | |||
| // we pessimistically set mayHaveNulls to check the entire vector instead of the selected range | |||
royi-luo
requested review from
ray6080
and removed request for
benjaminwinger
Benchmark ResultMaster commit hash:
|
royi-luo
force-pushed
the
royi/zone-map-add-exprs
branch
from
c906861 to
a142992
Compare
…l chunk + other refactoring
Benchmark ResultMaster commit hash:
|
ray6080
reviewed
Dec 19, 2024
| TypeUtils::visit(chunks[columnID]->getDataType().getPhysicalType(), | ||
| []<typename T>(T) { return StorageValueType<T>; })); | ||
| KU_ASSERT(columnHasStorageValueType || | ||
| columnZoneMapResult == common::ZoneMapCheckResult::ALWAYS_SCAN); |
There was a problem hiding this comment.
Why remove the runtime check?
There was a problem hiding this comment.
The runtime check no longer applies because the NULL-based skips can apply to non-storagevalue types
Benchmark ResultMaster commit hash:
|
royi-luo
force-pushed
the
royi/zone-map-add-exprs
branch
from
1bf3381 to
0e97a96
Compare
Benchmark ResultMaster commit hash:
|
ray6080
approved these changes
Dec 20, 2024
Benchmark ResultMaster commit hash:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for skipping chunked group scans based on zone map for
IS NULLandIS NOT NULLpredicatesContributor agreement