clean

kuzudb · Apr 12, 2024 · 4b88da2 · 4b88da2
1 parent 35dbbab
commit 4b88da2
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 8 deletions.
diff --git a/extension/httpfs/src/httpfs.cpp b/extension/httpfs/src/httpfs.cpp
@@ -193,7 +193,7 @@ int64_t HTTPFileSystem::readFile(common::FileInfo& fileInfo, void* buf, size_t n
     return numBytes;
 }
 
-void HTTPFileSystem::syncFile(const common::FileInfo&) {
+void HTTPFileSystem::syncFile(const common::FileInfo&) const {
     throw NotImplementedException("syncFile is not supported in HTTPFileSystem");
 }
 

diff --git a/extension/httpfs/src/include/httpfs.h b/extension/httpfs/src/include/httpfs.h
@@ -72,7 +72,7 @@ class HTTPFileSystem : public common::FileSystem {
 
     static std::unique_ptr<httplib::Headers> getHTTPHeaders(HeaderMap& headerMap);
 
-    void syncFile(const common::FileInfo& fileInfo) override;
+    void syncFile(const common::FileInfo& fileInfo) const override;
 
 protected:
     void readFromFile(common::FileInfo& fileInfo, void* buffer, uint64_t numBytes,

diff --git a/src/common/file_system/local_file_system.cpp b/src/common/file_system/local_file_system.cpp
@@ -287,7 +287,7 @@ void LocalFileSystem::writeFile(FileInfo& fileInfo, const uint8_t* buffer, uint6
     }
 }
 
-void LocalFileSystem::syncFile(const FileInfo& fileInfo) {
+void LocalFileSystem::syncFile(const FileInfo& fileInfo) const {
     auto& localFileInfo = ku_dynamic_cast<const FileInfo&, const LocalFileInfo&>(fileInfo);
     if (fsync(localFileInfo.fd)) {
         throw IOException(stringFormat("Failed to sync file {}.", fileInfo.path));

diff --git a/src/common/file_system/virtual_file_system.cpp b/src/common/file_system/virtual_file_system.cpp
@@ -60,7 +60,7 @@ void VirtualFileSystem::writeFile(FileInfo& /*fileInfo*/, const uint8_t* /*buffe
     KU_UNREACHABLE;
 }
 
-void VirtualFileSystem::syncFile(const FileInfo& fileInfo) {
+void VirtualFileSystem::syncFile(const FileInfo& fileInfo) const {
     findFileSystem(fileInfo.path)->syncFile(fileInfo);
 }
 

diff --git a/src/include/common/file_system/file_system.h b/src/include/common/file_system/file_system.h
@@ -45,7 +45,7 @@ class KUZU_API FileSystem {
 
     virtual bool canHandleFile(const std::string& /*path*/) const { KU_UNREACHABLE; }
 
-    virtual void syncFile(const FileInfo& fileInfo) = 0;
+    virtual void syncFile(const FileInfo& fileInfo) const = 0;
 
 protected:
     virtual void readFromFile(FileInfo& fileInfo, void* buffer, uint64_t numBytes,

diff --git a/src/include/common/file_system/local_file_system.h b/src/include/common/file_system/local_file_system.h
@@ -46,7 +46,7 @@ class LocalFileSystem final : public FileSystem {
 
     std::string expandPath(main::ClientContext* context, const std::string& path) const override;
 
-    void syncFile(const FileInfo& fileInfo) override;
+    void syncFile(const FileInfo& fileInfo) const override;
 
 protected:
     void readFromFile(FileInfo& fileInfo, void* buffer, uint64_t numBytes,

diff --git a/src/include/common/file_system/virtual_file_system.h b/src/include/common/file_system/virtual_file_system.h
@@ -32,7 +32,7 @@ class VirtualFileSystem final : public FileSystem {
 
     std::string expandPath(main::ClientContext* context, const std::string& path) const override;
 
-    virtual void syncFile(const FileInfo& fileInfo) override;
+    void syncFile(const FileInfo& fileInfo) const override;
 
 protected:
     void readFromFile(FileInfo& fileInfo, void* buffer, uint64_t numBytes,

diff --git a/src/storage/store/column_chunk.cpp b/src/storage/store/column_chunk.cpp
@@ -5,7 +5,6 @@
 #include "common/types/internal_id_t.h"
 #include "common/types/types.h"
 #include "storage/compression/compression.h"
-#include "storage/storage_utils.h"
 #include "storage/store/list_column_chunk.h"
 #include "storage/store/string_column_chunk.h"
 #include "storage/store/struct_column_chunk.h"