Allow using AdapterBase in MethodMock #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arusekk
approved these changes
Nov 25, 2024
|
The example test feels kind of weird. The most troubling thing is the active process: if forgotten, the test will be passing without testing anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopened rebased #7
I accidentally found new use for @def_method_mock (?), because it worked on older Transactron in other project.
It is nice to use (and more intuitive than in testbench example use) for proving input / collecting output of input-only and output-only Methods in modules, instead of writing call loops, and can be used directly for driving SimpleTestCircuit generated TestbenchIOs.