-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Age-ordered RS #783
Open
tilk
wants to merge
11
commits into
kuznia-rdzeni:master
Choose a base branch
from
tilk:age-order-rs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Age-ordered RS #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilk
added
enhancement
New feature or request
optimization
This is *just* an optimization!
benchmark
Benchmarks should be run for this change
labels
Jan 16, 2025
Benchmarks summaryPerformance benchmarks
You can view all the metrics here. Synthesis benchmarks (basic)
Synthesis benchmarks (full)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
benchmark
Benchmarks should be run for this change
enhancement
New feature or request
optimization
This is *just* an optimization!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes RS so that oldest entries are taken first. The idea is that the indexes in
get_ready_list
andtake
are no longer physical RS row numbers, but they are ordered from oldest to newest. The priority encoder inWakeupSelect
then naturally selects the oldest ready entry.The main RS test was extended to introduce random delays and testing multiple ready lists. The individual method tests are dropped, for three reasons: