Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Transactron #758

Merged
merged 7 commits into from
Nov 25, 2024
Merged

External Transactron #758

merged 7 commits into from
Nov 25, 2024

Conversation

tilk
Copy link
Member

@tilk tilk commented Nov 20, 2024

This PR finally extracts Transactron to external repo, https://github.com/kuznia-rdzeni/transactron. Depends on #754.

In the same time, the amaranth-stubs submodule is removed and replaced by an entry in requirements.txt. My reasons are:

  1. Installing local packages is not great when pyproject.toml is used. I'd like to move Coreblocks to pyproject.toml - I already did that in transactron.
  2. Workflows can be simplified, as the submodule doesn't need to be fetched before dependency installation.
  3. There are no real negative consequences for development - the local amaranth-stubs version needed to be installed using pip after each change anyway.

@tilk tilk added the refactor Doesn't change functionality, but makes stuff nicer label Nov 20, 2024
@tilk tilk force-pushed the tilk/external-transactron branch 2 times, most recently from f40f683 to 9afd86a Compare November 20, 2024 11:01
@piotro888
Copy link
Member

Would it make sense to rebase transactron repository on top of something like git-filter-repo (note: invocation is destructive!) with --path transactron/ --path test/transactron/ --path-rename test/transactron/:test/ --path coreblocks/transactions --replace-message <replace file with "#==>https://github.com/kuznia-rdzeni/coreblocks/pull/"> to keep easier to get history with valid PR references in one place?

@piotro888
Copy link
Member

Coreblocks README needs updating; and maybe docs/transactions.md should be preserved, but only with url to Transactron gh-pages docs?

@tilk
Copy link
Member Author

tilk commented Nov 25, 2024

Would it make sense to rebase transactron repository on top of something like git-filter-repo (note: invocation is destructive!) with --path transactron/ --path test/transactron/ --path-rename test/transactron/:test/ --path coreblocks/transactions --replace-message <replace file with "#==>https://github.com/kuznia-rdzeni/coreblocks/pull/"> to keep easier to get history with valid PR references in one place?

I just did that, but it unfortunately invalidated all active PRs in Transactron repo.

@tilk tilk force-pushed the tilk/external-transactron branch from abb1357 to 5db631b Compare November 25, 2024 14:29
@tilk tilk merged commit 2abd9e9 into master Nov 25, 2024
13 checks passed
@tilk tilk deleted the tilk/external-transactron branch November 25, 2024 14:47
github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Doesn't change functionality, but makes stuff nicer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants