Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synthesis of some configurations #750

Merged
merged 5 commits into from
Nov 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions coreblocks/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,11 @@ def elaborate(self, platform):

m.submodules.exception_information_register = self.exception_information_register

fetch_resume_fb, fetch_resume_unifiers = self.connections.get_dependency(FetchResumeKey())
m.submodules.fetch_resume_unifiers = ModuleConnector(**fetch_resume_unifiers)
if self.connections.dependency_provided(FetchResumeKey()):
fetch_resume_fb, fetch_resume_unifiers = self.connections.get_dependency(FetchResumeKey())
m.submodules.fetch_resume_unifiers = ModuleConnector(**fetch_resume_unifiers)

m.submodules.fetch_resume_connector = ConnectTrans(fetch_resume_fb, self.frontend.resume_from_unsafe)
m.submodules.fetch_resume_connector = ConnectTrans(fetch_resume_fb, self.frontend.resume_from_unsafe)

m.submodules.announcement = self.announcement
m.submodules.func_blocks_unifier = self.func_blocks_unifier
Expand Down
7 changes: 6 additions & 1 deletion coreblocks/frontend/fetch/fetch.py
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,12 @@ def _():
if self.gen_params.extra_verification:
expect_unstall_unsafe = Signal()
prev_stalled_unsafe = Signal()
unifier_ready = DependencyContext.get().get_dependency(FetchResumeKey())[0].ready
dependencies = DependencyContext.get()
if dependencies.dependency_provided(FetchResumeKey()):
unifier_ready = DependencyContext.get().get_dependency(FetchResumeKey())[0].ready
else:
unifier_ready = C(0)

m.d.sync += prev_stalled_unsafe.eq(stalled_unsafe)
with m.FSM("running"):
with m.State("running"):
Expand Down
2 changes: 1 addition & 1 deletion coreblocks/frontend/frontend.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def __init__(self, *, gen_params: GenParams, instr_bus: BusMasterInterface):
def elaborate(self, platform):
m = TModule()

if self.icache_refiller:
if self.gen_params.icache_params.enable:
m.submodules.icache_refiller = self.icache_refiller
m.submodules.icache = self.icache

Expand Down
7 changes: 5 additions & 2 deletions coreblocks/params/configurations.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,15 @@ def replace(self, **kwargs) -> Self:
tiny_core_config = CoreConfiguration(
embedded=True,
func_units_config=(
RSBlockComponent([ALUComponent(), ShiftUnitComponent(), JumpComponent()], rs_entries=2),
RSBlockComponent(
[ALUComponent(), ShiftUnitComponent(), JumpComponent(), ExceptionUnitComponent()], rs_entries=2
),
RSBlockComponent([LSUComponent()], rs_entries=2, rs_type=FifoRS),
),
phys_regs_bits=basic_core_config.phys_regs_bits - 1,
rob_entries_bits=basic_core_config.rob_entries_bits - 1,
allow_partial_extensions=True, # No exception unit
icache_enable=False,
user_mode=False,
)

# Core configuration with all supported components
Expand Down
2 changes: 1 addition & 1 deletion test/params/test_configurations.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class ISAStrTest:
"rv32imcbzicsr_zifencei_xintmachinemode",
"rv32imcbzicsr_zifencei_xintmachinemode",
),
ISAStrTest(tiny_core_config, "rv32e", "rv32", "rv32e"),
ISAStrTest(tiny_core_config, "rv32e", "rv32e", "rv32e"),
ISAStrTest(test_core_config, "rv32", "rv32", "rv32i"),
]

Expand Down
3 changes: 2 additions & 1 deletion test/test_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from coreblocks.core import Core
from coreblocks.params import GenParams
from coreblocks.params.instr import *
from coreblocks.params.configurations import CoreConfiguration, basic_core_config, full_core_config
from coreblocks.params.configurations import *
from coreblocks.peripherals.wishbone import WishboneMemorySlave

import random
Expand Down Expand Up @@ -131,6 +131,7 @@ def load_section(section: str):
[
("fibonacci", "fibonacci.asm", 500, {2: 2971215073}, basic_core_config),
("fibonacci_mem", "fibonacci_mem.asm", 400, {3: 55}, basic_core_config),
("fibonacci_mem_tiny", "fibonacci_mem.asm", 250, {3: 55}, tiny_core_config),
("csr", "csr.asm", 200, {1: 1, 2: 4}, full_core_config),
("csr_mmode", "csr_mmode.asm", 1000, {1: 0, 2: 44, 3: 0, 4: 0, 5: 0, 6: 4, 15: 0}, full_core_config),
("exception", "exception.asm", 200, {1: 1, 2: 2}, basic_core_config),
Expand Down
4 changes: 4 additions & 0 deletions transactron/utils/dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,10 @@ def get_dependency(self, key: DependencyKey[Any, U]) -> U:

return val

def dependency_provided(self, key: DependencyKey) -> bool:
"""Checks if any dependency for a key is provided (ignores `empty_valid` parameter)"""
return key in self.dependencies


class DependencyContext:
stack: list[DependencyManager] = []
Expand Down