Implement misa CSR
#743
Merged
Implement misa CSR
#743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilk
approved these changes
Nov 5, 2024
coreblocks/priv/csr/csr_instances.py
Outdated
| # 7 - Hypervisor, 18 - Supervisor, 23 - Custom Extensions | ||
|
|
||
| xml_field_mapping = {32: XlenEncoding.W32, 64: XlenEncoding.W64, 128: XlenEncoding.W128} | ||
| if gen_params.isa.xlen in xml_field_mapping: |
There was a problem hiding this comment.
We already verify that xlen is one of 32, 64, 128 (in ISA), so this condition should be always true - and if it's not, I believe it's a bug.
lekcyjna123
approved these changes
Nov 10, 2024
lekcyjna123
reviewed
Nov 10, 2024
| if extension in gen_params.isa.extensions: | ||
| misa_value |= 1 << bit | ||
|
|
||
| if gen_params.user_mode: |
There was a problem hiding this comment.
Why user_mode is handled separately? From ISA point of view it is "U" extension.
There was a problem hiding this comment.
It is treated as extension only in misa. It is not present in isa strings, not defined as extension in spec, doesn't define instructions and only changes CSR behaviour (and can't be determined from FU config, so needs config flag anyway)
I think it is better to not add it to isa.extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #561
Complete machine mode CSRs 🎉