Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore logging handler #716

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Restore logging handler #716

merged 1 commit into from
Jun 26, 2024

Conversation

xThaid
Copy link

@xThaid xThaid commented Jun 26, 2024

PR #573 accidentally broke logging by removing register_logging_handler from configure logging:

-    @pytest.fixture(autouse=True)
-    def configure_logging(self, fixture_sim_processes_to_add, register_logging_handler):
+    def configure_logging(self):

As a result, no logs were printed on the output.

I also found and removed an old print statement from test_log.py

@xThaid xThaid added the bug Something isn't working label Jun 26, 2024
@xThaid xThaid requested a review from lekcyjna123 June 26, 2024 10:58
@tilk tilk merged commit e454132 into kuznia-rdzeni:master Jun 26, 2024
13 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 26, 2024
tilk pushed a commit to kuznia-rdzeni/transactron that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants