Shift storage #709
Draft
Shift storage #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilk
reviewed
May 22, 2024
| @def_method(m, self.delete, ready=self._last > 0) | ||
| def _(addr): | ||
| m.d.top_comb += delete_address.eq(addr) | ||
| with m.If(addr < self._last): |
There was a problem hiding this comment.
What's the purpose of this If? It makes the delete not happen if a wrong address is passed. What's the use case? I believe this behavior could create silent bugs. Maybe use an assertion instead?
|
|
||
| @def_method(m, self.read) | ||
| def _(addr): | ||
| return {"data": self._data[addr], "valid": addr < self._last} |
There was a problem hiding this comment.
Do you have an use case for reading invalid addresses?
| m.d.top_comb += affected_by_delete.eq(addr > delete_address) | ||
| with m.If(update_req_valid & (last_decr.implies(delete_address != addr))): | ||
| m.d.sync += self._data[addr - Mux(last_decr, affected_by_delete, 0)].eq(data) | ||
| return {"err": ~update_req_valid} |
There was a problem hiding this comment.
Same as above. If there is no use case, I prefer an assertion to a bit which can be easily ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a PR with implemtation of shift storage to be used in LSU RS. I used hypothesis to do tests and now working with it was much more comfortable than previously.
TODO: