Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ring priority encoder #703

Merged
merged 8 commits into from
May 27, 2024

Conversation

lekcyjna123
Copy link
Contributor

@lekcyjna123 lekcyjna123 commented May 12, 2024

Few times we had already a problem, where we would like to select something from the circular buffer. I have hit this once more in RS LSU and accidentally I have found out how to solve that issue. So here is an RingMultiPriorityEncoder which can be used in such situations.

ToDo:

  • make the tests common for MultiPriorityEncoder and RingMultiPriorityEncoder

Based on #573

@lekcyjna123 lekcyjna123 force-pushed the lekcyjna/ring-priority-encoder branch from 0012060 to 84148ac Compare May 15, 2024 07:42
@lekcyjna123 lekcyjna123 marked this pull request as ready for review May 15, 2024 07:43
@lekcyjna123 lekcyjna123 requested a review from piotro888 May 20, 2024 16:48
transactron/utils/amaranth_ext/elaboratables.py Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MultiPriorityEncoder and RingMultiPriorityEncoder could be moved to separate file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let left this for a another review

@tilk tilk merged commit d6b357f into kuznia-rdzeni:master May 27, 2024
13 checks passed
github-actions bot pushed a commit that referenced this pull request May 27, 2024
tilk pushed a commit to kuznia-rdzeni/transactron that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants