DummyLSU as a FU #635
Merged
DummyLSU as a FU #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilk
added
enhancement
lekcyjna123
reviewed
Apr 2, 2024
test/lsu/test_dummylsu.py
Outdated
| @@ -180,7 +164,8 @@ def generate_instr(self, max_reg_val, max_imm_val): | |||
| } | |||
| ) | |||
|
|
|||
| self.exception_result.append( | |||
| print(f"addr:0x{addr:08x} misaligned:{misaligned} bus_err:{bus_err}") | |||
There was a problem hiding this comment.
Is this print intentional?
There was a problem hiding this comment.
This is probably a leftover from debugging, will remove.
lekcyjna123
approved these changes
Apr 3, 2024
xThaid
approved these changes
Apr 3, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Refactor RS, implement FifoRS * New RS test * Test FifoRS and fix bugs * Lint * Derive from RSBase * Workaround for Amaranth issue with Signal(range(1)) * First try * Fix bug * Try to break up critical path * Lint * LSU test, fix buuuugs * Fix PMA test * Move LSU * Remove debug print --------- Co-authored-by: lekcyjna123 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops, I did it again.
DummyLSUis now smaller, faster, and a FU. As this LSU is still dumb,FifoRSis used to maintain the instruction ordering. Still, having an actual RS for LSU allows for more latency hiding for memory requests.Depends on #634. Fixes #591.
TODO:
DummyLSUtofudirectory.