Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable division and bit manipulation extensions in benchmarks #616

Merged
merged 7 commits into from
Mar 12, 2024

Conversation

xThaid
Copy link

@xThaid xThaid commented Mar 11, 2024

Blocked until the new image is in the package registry.

Fixes #613.

I ran the benchmarks here: https://github.com/xThaid/coreblocks/actions/runs/8239973106/job/22534443637

@xThaid xThaid added the infrastructure CI, testing, etc. label Mar 11, 2024
@tilk
Copy link
Member

tilk commented Mar 11, 2024

The source of the riscv-arch-test test failure is actually in the building workflow:

 /__w/coreblocks/coreblocks/test/external/riscof/riscv-arch-test/riscv-test-suite/rv32i_m/I/src/jalr-01.S:72: Error: illegal operands `la x0,5b'

This looks unexpected.

@xThaid
Copy link
Author

xThaid commented Mar 11, 2024

I updated the toolchain, because I was getting errors when tried to compile the toolchain with Zb* extensions. I will take a look at this error.

@xThaid xThaid force-pushed the enable_b_in_benchmarks branch from a2acf3e to fb4e1e2 Compare March 12, 2024 16:05
@tilk tilk requested review from piotro888 and lekcyjna123 March 12, 2024 16:54
@tilk tilk merged commit 58249da into kuznia-rdzeni:master Mar 12, 2024
8 checks passed
@tilk
Copy link
Member

tilk commented Mar 13, 2024

It's pretty nice that the benchmark job now runs in 14 minutes instead of 16-17.

@piotro888
Copy link
Member

I reported the jalr test problem to riscv-arch-tests riscv-non-isa/riscv-arch-test#444

cause in binutils: bminor/binutils-gdb@27b3396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure CI, testing, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use division and bit extensions in IPC benchmarks
4 participants