Clean up pytest #611
Merged
Clean up pytest #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekcyjna123
approved these changes
Mar 10, 2024
tilk
approved these changes
Mar 10, 2024
6 tasks
tilk
pushed a commit
to kuznia-rdzeni/transactron
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__COREBLOCKS_DUMP_TRACES->__TRANSACTRON_DUMP_TRACES--coreblocks-regressionflag instead of not showing them at all.__TRANSACTRON_PROFILEis now set inpytest, so profiling can be also turned on using pytest flags.With these changes in, I suggest removing
run_tests.pyscripts, as it will be purely a wrapper overpytestcommand. My argument is thatrun_tests.pyscript is another layer of indirection that can contain bugs (#605) and needs to be understood when making changes.