Remove private _ModuleBuilderDomain #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would much rather prefer a protocol over a wrapper. Edit: but it looks like using a protocol would create problems for the check in |
tilk
requested changes
Feb 16, 2024
Co-authored-by: Marek Materzok <[email protected]>
tilk
reviewed
Feb 16, 2024
tilk
reviewed
Feb 19, 2024
added 2 commits
February 20, 2024 18:48
…kcyjna123/coreblocks into lekcyjna/remove-module-builder-domain
tilk
approved these changes
Feb 26, 2024
xThaid
approved these changes
Feb 27, 2024
tilk
pushed a commit
to kuznia-rdzeni/transactron
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
based on discussion from #577, it looks like
_ModuleBuilderDomainusage in transactron is not needed._ModuleBuilderDomainin amaranth is simply a wrapper, which puts data to the correct place__setattr__- as I understand - we check for the type to make sure that we are doing modification in place. This can be abstracted away with our internal class.