Update Amaranth version #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue filled. |
tilk
force-pushed
the
tilk/amaranth-update
branch
from
8d14041 to
26d710b
Compare
lekcyjna123
reviewed
Dec 3, 2023
stubs/amaranth/lib/enum.pyi
Outdated
| ... | ||
|
|
||
| def const(cls, init) -> Const: | ||
| ... | ||
|
|
||
|
|
||
| class E(IntEnum): |
There was a problem hiding this comment.
I don't see such class in amaranth
There was a problem hiding this comment.
And that's what CR is for ;)
lekcyjna123
approved these changes
Dec 3, 2023
piotro888
approved these changes
Dec 4, 2023
tilk
added a commit
to kuznia-rdzeni/transactron
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Amaranth to the latest version, in preparation for using
amaranth.lib.datain Transactron. Some fixes to typing and stubs are also included.Stubs for enums probably need to be changed because of Amaranth's RFC 31, but current stubs are good enough for now.I've changed the enum stubs to accomodate changes in Amaranth.