Implement LSU clear #499
Merged
Implement LSU clear #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekcyjna123
approved these changes
Nov 4, 2023
| @@ -271,9 +276,9 @@ def _(rob_id: Value): | |||
|
|
|||
| @def_method(m, self.clear) | |||
| def _(): | |||
| # TODO: clearing internal lsu component ;) | |||
| m.d.sync += current_instr.eq(0) | |||
| m.d.sync += current_instr.valid.eq(0) | |||
There was a problem hiding this comment.
If you have ready "load" instruction to execute, and you call clear in the same cycle, then load will start regardless of clear because (self.execute | is_load) will be true and instr_ready will be false first in next cycle.
Kristopher38
added a commit
to Kristopher38/coreblocks
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a proper clear method in
dummyLSUwith proper handling inLSUDummyInternals. As with most changes, bulk of the code is tests. Test code is a bit copy-paste'y as I didn't go for writing randomized tests (@lekcyjna123 already went through that route and it turned out to be a nightmare) and went with explicitly writing a sequence of steps that are supposed to test different conditions:get_resultyetThis merges into
feature/interruptssince that way I won't have to rebase against it (if it was merged intomaster).