Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Pyright version #485

Merged
merged 1 commit into from
Oct 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion constants/ecp5_platforms.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def __init__(self, pins: Iterable[str]):
def p(self, count: int = 1):
return " ".join([self.pin_bag.pop() for _ in range(count)])

def named_pin(self, names: list[str]):
def named_pin(self, names: Iterable[str]):
for name in names:
if name in self.pin_bag:
self.pin_bag.remove(name)
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ myst-parser==0.18.0
numpydoc==1.5.0
parameterized==0.8.1
pre-commit==2.16.0
pyright==1.1.308
pyright==1.1.332
Sphinx==5.1.1
sphinx-rtd-theme==1.0.0
sphinxcontrib-mermaid==0.8.1
Expand Down
6 changes: 3 additions & 3 deletions test/regression/cocotb.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ async def start(self):

while True:
while not (self.bus.stb.value and self.bus.cyc.value):
await clock_edge_event
await clock_edge_event # type: ignore

sig_m = WishboneMasterSignals()
self.bus.sample(sig_m)
Expand Down Expand Up @@ -124,10 +124,10 @@ async def start(self):
)

for _ in range(self.delay):
await clock_edge_event
await clock_edge_event # type: ignore

self.bus.drive(sig_s)
await clock_edge_event
await clock_edge_event # type: ignore
self.bus.drive(WishboneSlaveSignals())


Expand Down