Autumn cleaning part 4 - split test/common.py #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lekcyjna123
added
tests
tilk
reviewed
Oct 20, 2023
tilk
reviewed
Oct 23, 2023
tilk
approved these changes
Oct 24, 2023
lekcyjna123
requested review from
JumiDeluxe,
kindlermikolaj and
Durchbruchswagen
Durchbruchswagen
approved these changes
Oct 29, 2023
tilk
force-pushed
the
lekcyjna/autumn-cleaning-4
branch
from
8ec9f1b to
3b51d49
Compare
tilk
pushed a commit
to kuznia-rdzeni/transactron
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I have said, I have prepared a split of
test/common.py.Some remarks:
common.pytotransactron/_utils.pyaren't in final place. Probably they should go intotransactron/core/typing.py, but I don't want to do merge conflicts and_utils.pyis on the list to be refactored.data_layoutI moved it to_utils.pu, but now I think that this function should probably stay intest/common/functions.py.