-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python to 3.11 #473
Merged
Merged
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ea24527
Make TransactionBase a Protocol.
c60fa7c
Bump python
f62e0c5
Bump python version for docs
a236098
Update dockerfiles.
82150d1
Update riscv-toolchain.
be694e7
Break system packages.
8ca2be3
Add back setup python step.
f0068bf
Check if setup python without cache works.
283724f
Change command to install requirements.
662322c
Try to use venv instead of break-system-packages
d3dc874
Yet another way to initialise python env
a143490
Python3 update
72e0384
Docs update.
f47956c
Update dockerfiles.
d2e58b5
Update container path
47df59f
Change repository.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -14,7 +14,7 @@ jobs: | |||||
name: Synthesis benchmarks | ||||||
runs-on: ubuntu-latest | ||||||
timeout-minutes: 40 | ||||||
container: ghcr.io/kuznia-rdzeni/amaranth-synth:ecp5 | ||||||
container: ghcr.io/kuznia-rdzeni/amaranth-synth:ecp5-3.11 | ||||||
steps: | ||||||
- uses: actions/checkout@v3 | ||||||
|
||||||
|
@@ -23,19 +23,29 @@ jobs: | |||||
# https://github.com/actions/runner/issues/2033 | ||||||
chown -R $(id -u):$(id -g) $PWD | ||||||
|
||||||
- name: Set up Python | ||||||
uses: actions/setup-python@v4 | ||||||
with: | ||||||
python-version: '3.11' | ||||||
|
||||||
- name: Install dependencies | ||||||
run: | | ||||||
python3 -m venv venv | ||||||
. venv/bin/activate | ||||||
python3 -m pip install --upgrade pip | ||||||
pip3 install -r requirements-dev.txt | ||||||
python3 -m pip install -r requirements-dev.txt | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be enough with setup-python (especially when using venv, but even without it)
Suggested change
|
||||||
|
||||||
- name: Synthesize | ||||||
run: PYTHONHASHSEED=0 ./scripts/synthesize.py --verbose --config ${{ matrix.config }} | ||||||
run: | | ||||||
. venv/bin/activate | ||||||
PYTHONHASHSEED=0 ./scripts/synthesize.py --verbose --config ${{ matrix.config }} | ||||||
|
||||||
- name: Print synthesis information | ||||||
run: cat ./build/top.tim | ||||||
|
||||||
- name: Collect Benchmark information | ||||||
run: | | ||||||
. venv/bin/activate | ||||||
./scripts/parse_benchmark_info.py | ||||||
cat ./benchmark.json | ||||||
|
||||||
|
@@ -53,7 +63,7 @@ jobs: | |||||
build-perf-benchmarks: | ||||||
name: Build performance benchmarks | ||||||
runs-on: ubuntu-latest | ||||||
container: ghcr.io/kuznia-rdzeni/riscv-toolchain:2023.05.14 | ||||||
container: ghcr.io/lekcyjna123/riscv-toolchain:2023.10.08_v | ||||||
steps: | ||||||
- name: Checkout | ||||||
uses: actions/checkout@v3 | ||||||
|
@@ -73,7 +83,7 @@ jobs: | |||||
name: Run performance benchmarks | ||||||
runs-on: ubuntu-latest | ||||||
timeout-minutes: 60 | ||||||
container: ghcr.io/kuznia-rdzeni/verilator:v5.008 | ||||||
container: ghcr.io/kuznia-rdzeni/verilator:v5.008-3.11 | ||||||
needs: build-perf-benchmarks | ||||||
steps: | ||||||
- name: Checkout | ||||||
|
@@ -84,13 +94,22 @@ jobs: | |||||
# https://github.com/actions/runner/issues/2033 | ||||||
chown -R $(id -u):$(id -g) $PWD | ||||||
|
||||||
- name: Set up Python | ||||||
uses: actions/setup-python@v4 | ||||||
with: | ||||||
python-version: '3.11' | ||||||
|
||||||
- name: Install dependencies | ||||||
run: | | ||||||
python3 -m venv venv | ||||||
. venv/bin/activate | ||||||
python3 -m pip install --upgrade pip | ||||||
pip3 install -r requirements-dev.txt | ||||||
python3 -m pip install -r requirements-dev.txt | ||||||
|
||||||
- name: Generate Verilog | ||||||
run: PYTHONHASHSEED=0 ./scripts/gen_verilog.py --verbose --config full | ||||||
run: | | ||||||
. venv/bin/activate | ||||||
PYTHONHASHSEED=0 ./scripts/gen_verilog.py --verbose --config full | ||||||
|
||||||
- uses: actions/download-artifact@v3 | ||||||
with: | ||||||
|
@@ -99,6 +118,7 @@ jobs: | |||||
|
||||||
- name: Run benchmarks | ||||||
run: | | ||||||
. venv/bin/activate | ||||||
scripts/run_benchmarks.py | ||||||
|
||||||
- name: Store benchmark result (IPC) | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
FROM ubuntu:22.10 | ||
FROM ubuntu:23.04 | ||
|
||
RUN apt-get update && \ | ||
DEBIAN_FRONTEND=noninteractive \ | ||
apt-get install -y --no-install-recommends \ | ||
python3.10 python3-pip git yosys \ | ||
python3.11 python3-pip git yosys lsb-release \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this needed? Would love to see some explanation. |
||
build-essential cmake python3-dev libboost-all-dev libeigen3-dev && \ | ||
rm -rf /var/lib/apt/lists/* | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setup-python should make
python
enough; also, no need for venv I think, as the python that has been set up has one by default already (or is it the--break-system-packages
thing?)or even