Fix broken synthesis after cleanup #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotro888
approved these changes
Oct 7, 2023
Kristopher38
approved these changes
Oct 7, 2023
constants/ecp5_platforms.py
Outdated
| @@ -123,9 +123,12 @@ class ECP5BG756Platform(LatticeECP5Platform): | |||
| default_clk = "clk" | |||
| default_rst = "rst" | |||
|
|
|||
| clk_pin = pins.named_pin(ecp5_bg756_pclk) | |||
| if clk_pin is None: | |||
There was a problem hiding this comment.
this is required only to satisfy the typechecker, right?
There was a problem hiding this comment.
I would much rather throw an exception in the PinManager, and keep this code clean.
tilk
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #465. There was no type analysis activated for
constantsdirectory, so the error wasn't detected by pyright. Additionally there was one more type error, which is fixed by this MR.Synthesis job: https://github.com/kuznia-rdzeni/coreblocks/actions/runs/6433713558