-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autumn cleaning part 2 - split transactron/lib.py #464
Conversation
Bikeshedding time - I'd rename: Also with this scheme it feels like stuff in It also feels like the overall directory structure is reversed? Internal stuff like |
I very like @Kristopher38's suggestions. |
I pushed patches with @Kristopher38 ideas. Please say if they are according to your expectations.
This is also a great idea, but let leave it for separate PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
but let leave it for separate PR
alright, sounds good to me :)
In orginal code there was a bug in docstrings and API for |
As a next step I have chosen to split transactron/lib.py into smaller files. There is no changes, other than required to pass tests, to keep this merge request small. Please feel free to comment about directory names.