Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

feat: adding metric_url for reth #124

Merged
merged 10 commits into from
Sep 20, 2023

Conversation

loocapro
Copy link
Contributor

@loocapro loocapro commented Sep 14, 2023

Added metric_url in el context client

Linked to: ethpandaops/ethereum-package#195

src/el/el_client_context.star Outdated Show resolved Hide resolved
src/el/besu/besu_launcher.star Outdated Show resolved Hide resolved
src/el/erigon/erigon_launcher.star Outdated Show resolved Hide resolved
src/el/ethereumjs/ethereumjs_launcher.star Outdated Show resolved Hide resolved
src/el/reth/reth_launcher.star Show resolved Hide resolved
@cbermudez97
Copy link
Contributor

@lucaprov1989 @h4ck3rk3y I found having ethpandaops/ethereum-package#195 really useful and found out this PR adding some of the requirements for it. Created loocapro#1 to add configurations for other EL besides Reth. I would appreciate it if we could include those changes here too. 👍

@loocapro
Copy link
Contributor Author

@lucaprov1989 @h4ck3rk3y I found having kurtosis-tech/eth2-package#195 really useful and found out this PR adding some of the requirements for it. Created lucaprov1989#1 to add configurations for other EL besides Reth. I would appreciate it if we could include those changes here too. 👍

Hey @cbermudez97 thanks for this! I have just merged your integration.

Copy link
Contributor

@h4ck3rk3y h4ck3rk3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor changes left

src/el/besu/besu_launcher.star Show resolved Hide resolved
src/el/el_client_context.star Outdated Show resolved Hide resolved
src/el/ethereumjs/ethereumjs_launcher.star Show resolved Hide resolved
src/el/ethereumjs/ethereumjs_launcher.star Show resolved Hide resolved
@h4ck3rk3y h4ck3rk3y merged commit 566bcfc into kurtosis-tech:main Sep 20, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants