Fixed scenario runner node shutdown (carla-simulator#629)

* Fix scenario runner node for foxy * CHANGELOG updated
kuriatsu · Jul 21, 2022 · f47454a · f47454a
1 parent 4f52fe6
commit f47454a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 ## Latest changed
 
+*   Fixed scenario runner node shutdown for foxy
+*   Fixed actor synchronization creation
 *   Fix of scenario runner status
 
 ## CARLA-ROS-Bridge 0.9.11

diff --git a/carla_ad_demo/CMakeLists.txt b/carla_ad_demo/CMakeLists.txt
@@ -26,7 +26,7 @@ elseif(${ROS_VERSION} EQUAL 2)
 
   find_package(ament_cmake REQUIRED)
 
-  install(DIRECTORY config/ DESTINATION share/${PROJECT_NAME})
+  install(DIRECTORY config/ DESTINATION share/${PROJECT_NAME}/config)
 
   install(DIRECTORY launch/ DESTINATION share/${PROJECT_NAME})
 

diff --git a/carla_ros_scenario_runner/src/carla_ros_scenario_runner/carla_ros_scenario_runner_node.py b/carla_ros_scenario_runner/src/carla_ros_scenario_runner/carla_ros_scenario_runner_node.py
@@ -176,16 +176,16 @@ def main(args=None):
     try:
         scenario_runner.run()
     except KeyboardInterrupt:
-        loginfo("User requested shut down.")
+        scenario_runner.loginfo("User requested shut down.")
     finally:
         if scenario_runner._scenario_runner.is_running():
             scenario_runner.loginfo("Scenario Runner still running. Shutting down.")
             scenario_runner._scenario_runner.shutdown()
         del scenario_runner
-        if ROS_VERSION == 2:
-            spin_thread.join()
 
         roscomp.shutdown()
+        if ROS_VERSION == 2:
+            spin_thread.join()
 
 
 if __name__ == "__main__":