Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'how to deploy' #417

Merged
merged 2 commits into from
Dec 22, 2019
Merged

add 'how to deploy' #417

merged 2 commits into from
Dec 22, 2019

Conversation

kobakazu0429
Copy link
Member

closed #374

WHAT

やったこと

  • README.mdにdeploy方法の追記

@netlify
Copy link

netlify bot commented Nov 30, 2019

Deploy preview for cho-kure-web-storybook ready!

Built with commit c789f8b

https://deploy-preview-417--cho-kure-web-storybook.netlify.com

@kobakazu0429 kobakazu0429 changed the title add how to deploy add 'how to deploy' Nov 30, 2019
README.md Outdated
- production: `set :branch, "master"` in (/config/deploy/production.rb)
- staging: `set :branch, "feature/{xxxx}"` in (/config/deploy/staging.rb)
3. `$ bundle exec cap (staging | production) deploy`
4. `$ ssh (stg_cho_kure_web | cho_kure_web)` でサーバに入る
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% cat ~/.ssh/config
Host cho_kure_web
  HostName 52.199.95.54
  Port 22
  User euglena1215
  IdentityFile ~/.ssh/id_rsa

Host stg_cho_kure_web
  HostName 13.115.40.132
  Port 22
  User taira
  IdentityFile ~/.ssh/id_rsa

この設定が必要なのってどこかに書いてあるっけ?
書いてなかったらどっかに書いておいてほしい!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

今のところ何処にも書かれていないです!
githubにあげるのを躊躇って結局書かなかったんですよね

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これ自体は問題ないと思ってる!
これに加えて、対応する公開鍵(~/.ssh/id_rsa.pub)をサーバー側に置いておく必要があるから上記が広まったとしてもサーバーにアクセスできない限り問題なさそう

Copy link
Member

@euglena1215 euglena1215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

README.md Show resolved Hide resolved
@kobakazu0429 kobakazu0429 merged commit 75fb78a into feature/react Dec 22, 2019
@kobakazu0429 kobakazu0429 deleted the react/how-to-deploy branch December 22, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants