Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React/fix popular radio card #410

Merged
merged 7 commits into from
Nov 27, 2019

Conversation

kobakazu0429
Copy link
Member

@kobakazu0429 kobakazu0429 commented Nov 24, 2019

closed #288

WHY

データが仮置きだったので修正

WHAT

やったこと

  • (Styled) descriptionの除去
  • (Method) RadioStoreにshuffledRadioを生やした
  • (Storybook) RadioMiniCardを増やした

やってないこと

PopularRadio用のAPIがないのでradiosをシャッフルして表示させている
再生回数などを取れるようになったら修正したい -> #411

Demo

スクリーンショット 2019-11-24 22 15 51

@netlify
Copy link

netlify bot commented Nov 24, 2019

Deploy preview for cho-kure-web-storybook ready!

Built with commit dc94d96

https://deploy-preview-410--cho-kure-web-storybook.netlify.com

@netlify
Copy link

netlify bot commented Nov 24, 2019

Deploy preview for cho-kure-web-storybook ready!

Built with commit bd5ce69

https://deploy-preview-410--cho-kure-web-storybook.netlify.com

font-size: 1rem;
`;

// NOTE: DON'T REMOVE
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

descriptionも表示する時用のcss

Copy link
Member

@euglena1215 euglena1215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうな気がする

@kobakazu0429 kobakazu0429 merged commit 8f48d47 into feature/react Nov 27, 2019
@kobakazu0429 kobakazu0429 deleted the react/fix-popular-radio-card branch November 27, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants