storyshotsの導入 #398
Merged
storyshotsの導入 #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobakazu0429
force-pushed
the
react/storyshots
branch
from
2cac9aa to
ba500bf
Compare
kobakazu0429
force-pushed
the
react/storyshots
branch
from
49d7336 to
1f1070d
Compare
kobakazu0429
commented
Oct 11, 2019
| ? "file:///home/circleci/repo/frontend/storybook-static" | ||
| : "http://localhost:6006/"; | ||
|
|
||
| const beforeScreenshot: CustomConfig["beforeScreenshot"] = ( |
There was a problem hiding this comment.
circleciのcpuがしょぼくてレンダリングが終わらない時があるので、600 ms 遅らせている
| ); | ||
| }; | ||
|
|
||
| const getMatchOptions: CustomConfig["getMatchOptions"] = _context => ({ |
There was a problem hiding this comment.
macとdockerで微妙にフォント周りのレンダリングが変わってるみたいなので5%以内のdiffは許容するようにしてみた
これで様子を見てみて、運用が辛そうなら変更を考える
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #395
WHY
WHAT
やったこと
やってないこと