Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React/create radio card #373

Merged
merged 6 commits into from
Jul 9, 2019

Conversation

kobakazu0429
Copy link
Member

#372 の後にマージ

WHAT

やったこと

  • RadioHistoryページにrootStoreを流した

やってないこと

@kobakazu0429 kobakazu0429 mentioned this pull request Jun 26, 2019
7 tasks
@kobakazu0429 kobakazu0429 self-assigned this Jun 26, 2019
@kobakazu0429 kobakazu0429 requested a review from euglena1215 June 26, 2019 08:13
@euglena1215 euglena1215 changed the base branch from react/RadioCard-master to react/replace-mobx-react-lite July 8, 2019 18:15
Copy link
Member

@euglena1215 euglena1215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

見た!良さそう!
atomic designって何を原子にして何を分子にするみたいなのを明確にしないと崩壊するイメージあるから気をつけた方がよさそう 👀

return (
<Wrapper>
<Title>{title}</Title>
<Description dangerouslySetInnerHTML={{ __html: description }} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここはmarkdownを受け取るようになるんだよね?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これは前のAPIからhtmlを受け取ってます
別PRでmarkdownをパースして描画するようにしてます!

@kobakazu0429
Copy link
Member Author

atomic designについては別PRでREADMEに記載しておきます (#377)

@kobakazu0429
Copy link
Member Author

マージします!

@kobakazu0429 kobakazu0429 changed the base branch from react/replace-mobx-react-lite to react/RadioCard-master July 9, 2019 00:22
@kobakazu0429 kobakazu0429 merged commit a2230d2 into react/RadioCard-master Jul 9, 2019
@kobakazu0429 kobakazu0429 deleted the react/create-radio-card branch July 9, 2019 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants