-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React/create radio card #373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
見た!良さそう!
atomic designって何を原子にして何を分子にするみたいなのを明確にしないと崩壊するイメージあるから気をつけた方がよさそう 👀
return ( | ||
<Wrapper> | ||
<Title>{title}</Title> | ||
<Description dangerouslySetInnerHTML={{ __html: description }} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここはmarkdownを受け取るようになるんだよね?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これは前のAPIからhtmlを受け取ってます
別PRでmarkdownをパースして描画するようにしてます!
atomic designについては別PRでREADMEに記載しておきます (#377) |
マージします! |
#372 の後にマージ
WHAT
やったこと
やってないこと